Opened 7 months ago

Closed 5 months ago

#36156 closed Cleanup/optimization (fixed)

test_db_default_output_field_resolving errors on databases that do not support JSONField.

Reported by: Sage Abdullah Owned by: Kelvin Adigwu
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Running schema.tests.SchemaTests.test_db_default_output_field_resolving fails on databases that do not support JSONField, as it's missing a @skipUnlessDBFeature("supports_json_field") decorator.

See https://github.com/django/django-docker-box/pull/50#discussion_r1933066031 for more details.

Change History (8)

comment:1 by Simon Charette, 7 months ago

Triage Stage: UnreviewedAccepted

comment:2 by Simon Charette, 7 months ago

Easy pickings: set

comment:3 by Sage Abdullah, 7 months ago

Given the low-severity of the ticket and simpleness of the fix, I'm considering "reserving" this for the Djangonaut Space program. I'll be a navigator for the next session, which starts in ~a couple of weeks.

I hope that's OK. If anybody's not happy with it, let me know 😬

comment:4 by Simon Charette, 7 months ago

That sounds like a great idea Sage. Not sure if you want to claim ownership in the mean time to avoid causing confusion. It's not unusual for avid contributors to assign themselves "easy picking" tickets without reading the full context of the issue.

comment:5 by Sage Abdullah, 7 months ago

Thank you for the confirmation Simon! I already assigned the ticket when I created it 😄

comment:6 by Kelvin Adigwu, 6 months ago

Owner: changed from Sage Abdullah to Kelvin Adigwu

comment:7 by Mariusz Felisiak, 5 months ago

Has patch: set
Triage Stage: AcceptedReady for checkin

comment:8 by GitHub <noreply@…>, 5 months ago

Resolution: fixed
Status: assignedclosed

In 25f97e7b:

Fixed #36156 -- Added supports_json_field check in test_db_default_output_field_resolving test.

Note: See TracTickets for help on using tickets.
Back to Top