Opened 2 months ago

Last modified 6 weeks ago

#36156 assigned Cleanup/optimization

test_db_default_output_field_resolving errors on databases that do not support JSONField.

Reported by: Sage Abdullah Owned by: Kelvin Adigwu
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Running ​schema.tests.SchemaTests.test_db_default_output_field_resolving fails on databases that do not support JSONField, as it's missing a @skipUnlessDBFeature("supports_json_field") decorator.

See ​https://github.com/django/django-docker-box/pull/50#discussion_r1933066031 for more details.

According to the ticket's flags, the next step(s) to move this issue forward are:

  • To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is: [https://github.com/django/django/pull/#### PR].

Change History (6)

comment:1 by Simon Charette, 2 months ago

Triage Stage: Unreviewed → Accepted

comment:2 by Simon Charette, 2 months ago

Easy pickings: set

comment:3 by Sage Abdullah, 2 months ago

Given the low-severity of the ticket and simpleness of the fix, I'm considering "reserving" this for the Djangonaut Space program. I'll be a navigator for the next session, which starts in ~a couple of weeks.

I hope that's OK. If anybody's not happy with it, let me know 😬

comment:4 by Simon Charette, 2 months ago

That sounds like a great idea Sage. Not sure if you want to claim ownership in the mean time to avoid causing confusion. It's not unusual for avid contributors to assign themselves "easy picking" tickets without reading the full context of the issue.

comment:5 by Sage Abdullah, 2 months ago

Thank you for the confirmation Simon! I already assigned the ticket when I created it 😄

comment:6 by Kelvin Adigwu, 6 weeks ago

Owner: changed from Sage Abdullah to Kelvin Adigwu
Note: See TracTickets for help on using tickets.
Back to Top