Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#36148 closed Cleanup/optimization (fixed)

Enable native tuple comparison lookups on Oracle >= 23.4.

Reported by: Simon Charette Owned by: Simon Charette
Component: Database layer (models, ORM) Version: 5.2
Severity: Normal Keywords:
Cc: Mariusz Felisiak Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:19107 merged

Description

While I couldn't find the exact release note mention it appears that Oracle 23.4+ finally supports native tuple operations which makes most of the tuple_lookups Oracle specialization unnecessary on these versions.

Change History (5)

comment:1 by Sarah Boyce, 2 months ago

Cc: Mariusz Felisiak added
Owner: set to Simon Charette
Triage Stage: Unreviewed → Accepted

I also couldn't find a release note

comment:2 by Mariusz Felisiak, 2 months ago

Triage Stage: Accepted → Ready for checkin

comment:3 by Mariusz Felisiak <felisiak.mariusz@…>, 2 months ago

In a0a765dd:

Refs #36148 -- Relied on a feature switch to define tuple lookups support.

This should allow backends more easily opt-in or out of native support and rely
on the fallback if unavailable.

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 2 months ago

Resolution: → fixed
Status: assigned → closed

In 4a3ad9ee:

Fixed #36148 -- Enabled native tuple comparison lookups on SQLite 3.37+ and Oracle 23.4+.

VALUES must be explicitly specified when declaring a sequence of tuples
on SQLite < 3.37 but it's not required on >= 3.37.

See sqlite/sqlite@9289f51 which addressed the last remaining issue with
IN.

comment:5 by Sarah Boyce <42296566+sarahboyce@…>, 2 months ago

In f8fce8d:

[5.2.x] Refs #36148 -- Relied on a feature switch to define tuple lookups support.

This should allow backends more easily opt-in or out of native support and rely
on the fallback if unavailable.

Backport of a0a765ddeb5056c85e084773d3f6432e2a426638 from main.

Note: See TracTickets for help on using tickets.
Back to Top