Opened 3 weeks ago
Last modified 2 days ago
#36127 assigned Bug
The link is not displayed when str is blank in admin.
Reported by: | Antoliny | Owned by: | Antoliny |
---|---|---|---|
Component: | contrib.admin | Version: | 5.1 |
Severity: | Normal | Keywords: | link |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Pull Requests: | 19105 | ||
Description ¶
In the admin page, there are parts where the model's __str__
value is used, providing links that allow navigation to the object when the value is clicked.
However, when __str__
is blank, while it’s not an issue for the value to appear as blank, the <a>
tag's innerHTML
being empty prevents the layout from being displayed on the screen, and it also cannot function as a link.
While it’s very rare for a user to assign a blank value to __str__
, I still believe that it should at least function as a link.
Just like with fields, when the value is blank, a default value such as "-" should be used to ensure that it can at least function as a link.
According to the ticket's flags, the next step(s) to move this issue forward are:
- For anyone except the patch author to review the patch using the patch review checklist and either mark the ticket as "Ready for checkin" if everything looks good, or leave comments for improvement and mark the ticket as "Patch needs improvement".
Change History (11)
by , 3 weeks ago
Attachment: | not_link_example.png added |
---|
comment:1 by , 3 weeks ago
Owner: | set to |
---|---|
Status: | new → assigned |
Type: | Uncategorized → Bug |
comment:2 by , 3 weeks ago
Triage Stage: | Unreviewed → Accepted |
---|---|
UI/UX: | set |
by , 3 weeks ago
Attachment: | Screenshot 2025-01-24 at 8.15.43 AM.png added |
---|
by , 3 weeks ago
Attachment: | Screenshot 2025-01-24 at 8.16.41 AM.png added |
---|
comment:3 by , 3 weeks ago
comment:5 by , 3 weeks ago
Needs tests: | set |
---|
comment:6 by , 2 weeks ago
Needs tests: | unset |
---|
comment:7 by , 2 weeks ago
Patch needs improvement: | set |
---|
comment:8 by , 2 days ago
Patch needs improvement: | unset |
---|
Similar nature to #36114
It will be difficult to find all of these but we can try 👍