Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#36102 closed Bug (fixed)

Some Translators comments are dissapearing from the po files

Reported by: Julien Palard Owned by: Julien Palard
Component: contrib.humanize Version: 5.1
Severity: Normal Keywords: i18n
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

cf. ​https://forum.djangoproject.com/t/xgettext-and-comments/37967/3

Since 9c19aff7c7561e3a82978a272ecdaad40dda5c00 a few translators comments are no longer picked up by xgettext.

They just need to be moved one line down.

Change History (5)

comment:1 by Claude Paroz, 10 months ago

Has patch: set
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

comment:2 by JaeHyuckSa, 10 months ago

Owner: set to Julien Palard
Status: new → assigned

comment:3 by Claude Paroz, 9 months ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:4 by Sarah Boyce <42296566+sarahboyce@…>, 9 months ago

Resolution: → fixed
Status: assigned → closed

In 6fcd0440:

Fixed #36102 -- Moved i18n comments directly above the translatable string.

xgettext only extracts comment blocks if there is no program code between
the comment and the string that gets extracted. For details, see:
​https://www.gnu.org/software/gettext/manual/html_node/xgettext-Invocation.html#Operation-mode

Black formatting has been turned off in some places to ensure the
comments are not moved, which previously resulted in them being removed
from the po files when scripts/manage_translations.py was run.

comment:5 by Sarah Boyce <42296566+sarahboyce@…>, 9 months ago

In e623010:

[5.2.x] Fixed #36102 -- Moved i18n comments directly above the translatable string.

xgettext only extracts comment blocks if there is no program code between
the comment and the string that gets extracted. For details, see:
​https://www.gnu.org/software/gettext/manual/html_node/xgettext-Invocation.html#Operation-mode

Black formatting has been turned off in some places to ensure the
comments are not moved, which previously resulted in them being removed
from the po files when scripts/manage_translations.py was run.

Backport of 6fcd0440aaa7601aa258d1c956eecfaedf72fbf4 from main.

Note: See TracTickets for help on using tickets.
Back to Top