Opened 5 weeks ago
Last modified 4 weeks ago
#36079 assigned Cleanup/optimization
Size of the object's str in TabularInline is too small
Reported by: | Antoliny | Owned by: | Antoliny |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | Inline, Font, accessibility |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Pull Requests: | 19118 | ||
Description (last modified by ) ¶
I feel that the str
of the object positioned above the form inside the TabularInline
is too small.
(There is a significant difference in the object str
representation between TabularInline
and StackedInline
.)
I think it would be better if the size were a bit larger or matches the size of StackedInline
.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Change History (10)
by , 5 weeks ago
Attachment: | tabular_inline_object_str.png added |
---|
comment:1 by , 5 weeks ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:2 by , 5 weeks ago
Version: | 5.1 → dev |
---|
by , 5 weeks ago
Attachment: | inline_object_str_diff.png added |
---|
comment:3 by , 5 weeks ago
Description: | modified (diff) |
---|
comment:4 by , 5 weeks ago
Summary: | Size of the object's str in inline → Size of the object's str in TabularInline |
---|
comment:5 by , 5 weeks ago
Keywords: | accessibility added |
---|---|
Summary: | Size of the object's str in TabularInline → Size of the object's str in TabularInline is too small |
Triage Stage: | Unreviewed → Accepted |
UI/UX: | set |
by , 5 weeks ago
Attachment: | inline_fields_layout.png added |
---|
comment:6 by , 5 weeks ago
The main difference between TabularInline
and StackedInline
is the row/column arrangement of the fields.
Therefore, I don't think the headers of the forms inside TabularInline
and StackedInline
need to be in different formats. How about making the form headers inside both TabularInline
and StackedInline
the same style?
Even if they are the same, I believe the differences in their layouts (row/column) are enough to distinguish them. If they are the same, I personally prefer the header style of StackedInline
😃(especially considering situations with many forms)
Agreed, this will likely need some input from the accessibility team