Opened 12 months ago
Closed 12 months ago
#35917 closed New feature (wontfix)
add IrSlug converter
| Reported by: | ahmadrezanavaie | Owned by: | |
|---|---|---|---|
| Component: | Core (URLs) | Version: | 5.1 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
As an amateur, I requested to add a slug specifically for Persian and Arabic phrases that may also contain English to Django. These were the changes I made in the converters.py file. Do you think there are any issues?
The PR link : https://github.com/django/django/pull/18826
class IrSlugConverter(StringConverter):
regex = "[-a-zA-Z0-9_\u0600-\u06FF]+"
DEFAULT_CONVERTERS = {
"int": IntConverter(),
"path": PathConverter(),
"slug": SlugConverter(),
"irslug": IrSlugConverter(),
"str": StringConverter(),
"uuid": UUIDConverter(),
}
Change History (2)
comment:1 by , 12 months ago
| Description: | modified (diff) |
|---|
comment:2 by , 12 months ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Thanks for this ticket, however the current thread is to keep Django a core framework, not providing every utility which might be useful.
Please follow triaging guidelines with regards to wontfix tickets and take this to DevelopersMailingList, if you don't agree.