Opened 5 months ago

Closed 5 months ago

#35903 closed Cleanup/optimization (fixed)

"view on site" URL doesn't accept non-integer ContentType pks

Reported by: Tim Graham Owned by: Tim Graham
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Most admin URL paths use the path converter to allow any type of ID, however, the "view on site" uses the int converter for content_type_id.

This doesn't work on MongoDB which uses ObjectIdAutoField (bson.ObjectId) for all models since AutoField isn't supported.

Change History (4)

comment:1 by Tim Graham, 5 months ago

Has patch: set

​PR

comment:2 by Natalia Bidart, 5 months ago

Triage Stage: Unreviewed → Accepted
Version: 5.0 → dev

Thank you Tim for this report, I think your proposed solution makes sense and it's a good improvement.

comment:3 by Sarah Boyce, 5 months ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Sarah Boyce <42296566+sarahboyce@…>, 5 months ago

Resolution: → fixed
Status: assigned → closed

In ef8ae06c:

Fixed #35903 -- Made admin's "view on site" URL accept non-integer ContentType pks.

Note: See TracTickets for help on using tickets.
Back to Top