Opened 5 weeks ago
Last modified 3 days ago
#35886 assigned New feature
Move object-based media assets to the public API
Reported by: | Johannes Maron | Owned by: | Johannes Maron |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Johannes Maron, Tobias Kunze, David Smith | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
This is a successor to #29490 and a result of the discussion on #22298 and its corresponding forum thread.
This ticket aims to move object-based media assets to the public API and documentation.
A sample implementation has been part of the test suite for years, see also: https://github.com/django/django/blob/97a6a678c406b0049bd17bcd34f1d71d96141994/tests/forms_tests/tests/test_media.py#L717-L771
The goal is to support form assets with modern attributes, like:
<script type="module"> <!-- or --> <script defer> <!-- or --> <script async>
And other standardized attributes, see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
The same can be done for stylesheets via the link tag, which does support many more attributes than media
, see also: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link
Considerations
We could deprecate "string" based assets. This may simplify django.forms
since, the CSS grouping wouldn't be needed anymore.
Change History (6)
comment:1 by , 5 weeks ago
Cc: | added |
---|---|
Triage Stage: | Unreviewed → Accepted |
Type: | Cleanup/optimization → New feature |
comment:2 by , 4 weeks ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:3 by , 4 weeks ago
Has patch: | set |
---|
comment:4 by , 8 days ago
Patch needs improvement: | set |
---|
comment:5 by , 8 days ago
Patch needs improvement: | unset |
---|
comment:6 by , 3 days ago
Needs tests: | set |
---|
Accepting based off the forum discussion