related.py's OneToOneField.formfield erroneously uses kwargs instead of defaults
|Reported by:||Andrew Sutherland <andrew@…>||Owned by:||adrian|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
In related.py, OneToOneField.formfield takes kwargs, initializes the defaults dict, updates the defaults dict with the contents of kwargs, then just passes kwargs to ModelChoiceField, never doing anything with defaults again. The other similar methods in the file use defaults, I assume this was a typo.
Attaching the trivial patch, and setting to django.newforms since that's where #3257 which touched this was binned.
Change History (3)
Changed 10 years ago by Andrew Sutherland <andrew@…>
comment:1 Changed 10 years ago by Gary Wilson <gary.wilson@…>
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Ready for checkin