#35786 closed Bug (fixed)
AddField reference to Django's support for database defaults is outdated
| Reported by: | Václav Řehák | Owned by: | Ahmed Nassar |
|---|---|---|---|
| Component: | Documentation | Version: | 5.1 |
| Severity: | Normal | Keywords: | db_default |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The docs of AddField at https://docs.djangoproject.com/en/dev/ref/migration-operations/#addfield says
It does not affect the behavior of setting defaults in the database directly - Django never sets database defaults and always applies them in the Django ORM code.
I think this wording is confusing because since adding db_default Django ORM actually does set db defaults. The same sentence is present in AlterField docs.
Change History (7)
comment:1 by , 18 months ago
comment:2 by , 18 months ago
| Keywords: | db_default added |
|---|---|
| Summary: | Incorrect info about database defaults in migrations doc → AddField reference to Django's support for database defaults is outdated |
| Triage Stage: | Unreviewed → Accepted |
Nice catch!
comment:3 by , 18 months ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:4 by , 11 months ago
| Owner: | changed from to |
|---|
Due to owner's inactivity. I'll work on this ticket and submit my PR soon.
comment:5 by , 5 days ago
| Has patch: | set |
|---|
Note:
See TracTickets
for help on using tickets.
Btw, there was already a comment about this 8 years ago, see https://code.djangoproject.com/ticket/26476#comment:3
"arguably, the documentation is not clear enough; what is meant is that Django never leaves defaults in the database."