Opened 14 months ago

Closed 10 months ago

#35740 closed Bug (fixed)

file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails when bcachefs is in use

Reported by: Alyssa Ross Owned by: YashRaj1506
Component: File uploads/storage Version: 4.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This test constructs a file name of the maximum permissible length reported by the filesystem, then checks that round-tripping it through a FileField with a max_length of 300. If the filesystem reports a maximum permissible length longer than 300, this won't work, because the name will have been truncated by the FileField.

Change History (10)

comment:1 by Alyssa Ross, 14 months ago

Owner: set to Alyssa Ross
Status: new → assigned

comment:2 by Alyssa Ross, 14 months ago

Owner: Alyssa Ross removed
Status: assigned → new

comment:3 by Sarah Boyce, 14 months ago

Summary: test_extended_length_storage fails on bcachefs → file_storage.tests.FileFieldStorageTests.test_extended_length_storage fails when bcachefs is in use

Refs #24826
Do you have a suggested patch?

comment:4 by Sarah Boyce, 14 months ago

Resolution: → needsinfo
Status: new → closed

Increasing the max_length for extended_length might work but I can't find what this number should be for ​bcachefs.

  • tests/file_storage/models.py

    a b class Storage(models.Model):  
    8080        storage=temp_storage, upload_to="tests", max_length=20
    8181    )
    8282    extended_length = models.FileField(
    83         storage=temp_storage, upload_to="tests", max_length=300
     83        storage=temp_storage, upload_to="tests", max_length=2000
    8484    )

Can you share what _storage_max_filename_length returns for you?

comment:5 by Alyssa Ross, 13 months ago

Resolution: needsinfo
Status: closed → new

Hi! Sorry, I missed the notification.

PC_NAME_MAX on bcachefs is 512.

comment:6 by Sarah Boyce, 13 months ago

Triage Stage: Unreviewed → Accepted

comment:7 by YashRaj1506, 11 months ago

Owner: set to YashRaj1506
Status: new → assigned

comment:8 by YashRaj1506, 11 months ago

Has patch: set

comment:9 by Sarah Boyce, 10 months ago

Triage Stage: Accepted → Ready for checkin

comment:10 by Sarah Boyce <42296566+sarahboyce@…>, 10 months ago

Resolution: → fixed
Status: assigned → closed

In 12f4f954:

Fixed #35740 -- Fixed FileFieldStorageTests.test_extended_length_storage when using bcachefs.

PC_NAME_MAX on bcachefs is 512, which was greater than the file field max_length.

Note: See TracTickets for help on using tickets.
Back to Top