Opened 15 months ago

Closed 14 months ago

Last modified 9 months ago

#35704 closed Bug (fixed)

AddIndexConcurrently + RenameIndex incorrectly reduces to AddIndex

Reported by: Adam Johnson Owned by: Adam Johnson
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

A migration with AddIndexConcurrently and RenameIndex for the same index will turn into an AddIndex. This means that, for example, optimizemigration can change a migration to use extra locking, which may be unsafe.

(Discovered after working on some other missing optimizations in #35700.)

Change History (5)

comment:1 by Simon Charette, 15 months ago

Triage Stage: Unreviewed → Accepted

comment:2 by Sarah Boyce, 14 months ago

Has patch: set

​PR

comment:3 by Sarah Boyce, 14 months ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Sarah Boyce <42296566+sarahboyce@…>, 14 months ago

Resolution: → fixed
Status: assigned → closed

In f5ddd54:

Fixed #35704 -- Fixed reduction for AddIndex subclasses.

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 9 months ago

In c07ba43c:

Refs #35704 -- Used copy.replace() in Operation.reduce() methods.

Note: See TracTickets for help on using tickets.
Back to Top