Opened 3 months ago
Closed 3 months ago
#35702 closed Cleanup/optimization (fixed)
Clarify mysqlclient does not provide connection pooling
Reported by: | Hisham Mahmood | Owned by: | Hisham Mahmood |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The mysqlclient driver does not provide connection pooling, we also don't ship it. I think we should clarify this here.
Change History (5)
comment:1 by , 3 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 3 months ago
Owner: | set to |
---|---|
Status: | new → assigned |
The mysqlclient
driver is a fork of MySQLdb
. It included a reference to a pool module, that was removed. Besides this mention, I don’t think MySQLdb
has had pool support either.
comment:4 by , 3 months ago
Triage Stage: | Accepted → Ready for checkin |
---|
Note:
See TracTickets
for help on using tickets.
The note about
mysqlclient
being thread safe and implementing connection pooling was inherited in #23446 (7f089ac2e3e6a7f4b2b41085a37d35e074fad805). The thread safety and connection pooling claims were added forMySQLDB
originally but they are certainly not true for eitherpymysql
ormysqlclient
.As pointed out in their docs
I would remove the thread safety claims as well.