Test stack level of deprecation warnings
With another improperly set instance of stacklevel
and few others behind our belt I think it's worth documenting and adjusting our test suite to systematically test against the assertWarnsMessage.filename
to ensure is it properly assigned.
Owner: |
set to Simon Charette
|
Severity: |
Normal → Release blocker
|
Status: |
new → assigned
|
Triage Stage: |
Unreviewed → Accepted
|
Summary: |
Stack level of deprecation warnings should be tested → Test stack level of deprecation warnings
|
Needs documentation: |
set
|
Patch needs improvement: |
set
|
Needs documentation: |
unset
|
Patch needs improvement: |
unset
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
Thank you Simon, I agree with your rationale.
I think some of the commits from your PR should be backported to
5.1
so I'll be marking this as a release blocker for5.1
.