#35645 closed Bug (fixed)
Inline H3 header style is visually stronger than the page's H1 (admin, light theme).
Description ¶
Following the review of PR 18308 (which fixes #35558 and a fix landed in e510bb1ab1fb22837c169e0459b81cf388b6d8d2), it was noticed that since the inline H3 header was set to --body-loud-color
, in the light theme this color (black) is stronger than the page's H1, which is --body-quiet-color
(#666
, dark-ish gray).
The page's H1 should be visually stronger than the H2 and H3 headings, so I'm proposing to:
- Have the table headers for
required
fields use--body-fg
(#333
), instead of black, to match what every otherrequired
form label uses, and to visually show a difference between the inline H3 and its content (this is what motivated the changes in #35558). - Have the page's H1 use
--body-loud-color
to ensure this header is visually stronger than any other heading in the page.
PR coming up shortly.
Change History (6)
comment:1 by , 7 months ago
Has patch: | set |
---|
comment:2 by , 7 months ago
Severity: | Normal → Release blocker |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 7 months ago
Patch needs improvement: | set |
---|
comment:5 by , 7 months ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Thank you for following up
Unfortunately this would require an update to almost all images in
docs/ref/contrib/admin/_images
anddocs/intro/_images