Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#35540 closed Bug (fixed)

Admin login form padding issue

Reported by: Sarah Boyce Owned by: arjun omray
Component: contrib.admin Version: 5.1
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Sarah Boyce)

If you look at the tutorial with an older screenshot of the Django admin, we're expecting some padding below the login button: ​https://docs.djangoproject.com/en/5.0/intro/tutorial02/#start-the-development-server

Current


Suggested update:

  • django/contrib/admin/static/admin/css/login.css 

    diff --git a/django/contrib/admin/static/admin/css/login.css b/django/contrib/admin/static/admin/css/login.css
index 389772f5bc..805a34b5bd 100644
    a b  
    2121}
    2222
    2323.login #content {
    24     padding: 20px 20px 0;
     24    padding: 20px;
    2525}
    2626
    2727.login #container {

After


Whoever picks this up should also update the image docs/intro/_images/admin01.png so that it has the latest styles 👍

Attachments (2)

image-20240620-130503.png​ (11.3 KB ) - added by Sarah Boyce 6 months ago.
image-20240620-130526.png​ (11.3 KB ) - added by Sarah Boyce 6 months ago.

Download all attachments as: .zip

Change History (11)

by Sarah Boyce, 6 months ago

Attachment: image-20240620-130503.png​ added

by Sarah Boyce, 6 months ago

Attachment: image-20240620-130526.png​ added

comment:1 by Sarah Boyce, 6 months ago

Description: modified (diff)

comment:2 by Anthony Kugel, 6 months ago

Owner: changed from nobody to Anthony Kugel
Status: new → assigned

comment:3 by Natalia Bidart, 6 months ago

Triage Stage: Unreviewed → Accepted
UI/UX: set

Another great catch, thank you Sarah! Confirmed that 5.0 is not affected.

comment:4 by arjun omray, 6 months ago

Hey, can I work on this issue if it is available?

in reply to:  4 comment:5 by Sarah Boyce, 6 months ago

Severity: Normal → Release blocker

As 5.0 is not affected, marking as a release blocker for 5.1

Replying to arjun omray:

Hey, can I work on this issue if it is available?

I see Anthony assigned themselves recently but hasn't raised a PR. As we will need an update here relatively soon, I would say yes you can work on it.
Normally I would say we should wait a bit longer but release blockers are special cases

comment:6 by arjun omray, 6 months ago

Has patch: set
Owner: changed from Anthony Kugel to arjun omray

​https://github.com/django/django/pull/18306

Okay, I have raised a PR for this ticket.

comment:7 by Sarah Boyce, 6 months ago

Triage Stage: Accepted → Ready for checkin

comment:8 by Sarah Boyce <42296566+sarahboyce@…>, 6 months ago

Resolution: → fixed
Status: assigned → closed

In d9bd58c:

Fixed #35540 -- Fixed the padding on admin login page.

comment:9 by Sarah Boyce <42296566+sarahboyce@…>, 6 months ago

In ddf81f0:

[5.1.x] Fixed #35540 -- Fixed the padding on admin login page.

Backport of d9bd58c3b8b3e8735d8242c2bb9b09c52ed6171b from main.

Note: See TracTickets for help on using tickets.
Back to Top