#35540 closed Bug (fixed)
Admin login form padding issue
Reported by: | Sarah Boyce | Owned by: | arjun omray |
---|---|---|---|
Component: | contrib.admin | Version: | 5.1 |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
If you look at the tutorial with an older screenshot of the Django admin, we're expecting some padding below the login button: https://docs.djangoproject.com/en/5.0/intro/tutorial02/#start-the-development-server
Current
Suggested update:
-
django/contrib/admin/static/admin/css/login.css
diff --git a/django/contrib/admin/static/admin/css/login.css b/django/contrib/admin/static/admin/css/login.css index 389772f5bc..805a34b5bd 100644
a b 21 21 } 22 22 23 23 .login #content { 24 padding: 20px 20px 0;24 padding: 20px; 25 25 } 26 26 27 27 .login #container {
After
Whoever picks this up should also update the image docs/intro/_images/admin01.png
so that it has the latest styles 👍
Attachments (2)
Change History (11)
by , 4 months ago
Attachment: | image-20240620-130503.png added |
---|
by , 4 months ago
Attachment: | image-20240620-130526.png added |
---|
comment:1 by , 4 months ago
Description: | modified (diff) |
---|
comment:2 by , 4 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 4 months ago
Triage Stage: | Unreviewed → Accepted |
---|---|
UI/UX: | set |
comment:5 by , 4 months ago
Severity: | Normal → Release blocker |
---|
As 5.0 is not affected, marking as a release blocker for 5.1
Replying to arjun omray:
Hey, can I work on this issue if it is available?
I see Anthony assigned themselves recently but hasn't raised a PR. As we will need an update here relatively soon, I would say yes you can work on it.
Normally I would say we should wait a bit longer but release blockers are special cases
comment:6 by , 4 months ago
Has patch: | set |
---|---|
Owner: | changed from | to
https://github.com/django/django/pull/18306
Okay, I have raised a PR for this ticket.
comment:7 by , 4 months ago
Triage Stage: | Accepted → Ready for checkin |
---|
Another great catch, thank you Sarah! Confirmed that 5.0 is not affected.