Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#35472 closed Cleanup/optimization (fixed)

Image files aren't cleaned up after running tests

Reported by: bcail Owned by: nobody
Component: File uploads/storage Version: 5.1
Severity: Release blocker Keywords:
Cc: bcail Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

After each run of the django test suite, I'm seeing two image files ("mug*") left on the filesystem. It looks like the issue is from this commit: 9c5fe93349bd4339c41d057b87046e5d28be6f77.

Change History (5)

comment:1 by Sarah Boyce, 5 months ago

Component: UncategorizedFile uploads/storage
Has patch: set
Triage Stage: UnreviewedAccepted
Version: dev5.1

Thank you bcail!
Yes, this was introduced in 9c5fe93349bd4339c41d057b87046e5d28be6f77 (#35139), I have raised a patch. I think we should backport this into 5.1 👍

comment:2 by Natalia Bidart, 5 months ago

Severity: NormalRelease blocker

Marking as release blocker so we backport to stable/5.1.x.

comment:3 by nessita <124304+nessita@…>, 5 months ago

Resolution: fixed
Status: newclosed

In 7e39ae5:

Fixed #35472 -- Used temporary directory in test_imagefield.NoReadTests.

comment:4 by Natalia <124304+nessita@…>, 5 months ago

In 501e32a:

[5.1.x] Fixed #35472 -- Used temporary directory in test_imagefield.NoReadTests.

Backport of 7e39ae5c8cf4c6601a4f47b72914349481c5331b from main.

comment:5 by Natalia Bidart, 5 months ago

Triage Stage: AcceptedReady for checkin
Note: See TracTickets for help on using tickets.
Back to Top