AdminEmailHandler wastes work when ADMINS isn’t set

[Adam Johnson]

AdminEmailHandler.emit() does a lot of work to assemble the message it passes to mail_admins. If settings.ADMINS is empty, mail_admins() returns instantly, wasting all the message-creation work. It’s quite common to not configure ADMINS, whether in lieu of more advanced tools like Sentry, or during tests.

In a quick benchmark on my M1 Mac Pro on Python 3.11, the overhead is ~2.5ms:

In [1]: import logging

In [2]: logger = logging.getLogger('django')

In [3]: %timeit logger.error("Yada")
...
2.78 ms ± 75.4 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

In [4]: logger = logging.getLogger('example')

In [5]: %timeit logger.error("Yada")
...
8.37 µs ± 38.9 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

This can be avoided by adding an initial check to AdminEmailHandler.emit().

[Natalia Bidart]

Makes sense, thank you!

[Mariusz Felisiak]

​PR

[Sarah Boyce <42296566+sarahboyce@…>]

In b0f2289:

Refs #35364 -- Tested AdminEmailHandler with empty ADMINS.

[Sarah Boyce <42296566+sarahboyce@…>]

In 50a702f:

Fixed #35364 -- Stopped AdminEmailHandler rendering email unnecessarily.