Opened 8 months ago

Last modified 3 weeks ago

#35358 new Cleanup/optimization

Rename BaseConstraint._check() to check()

Reported by: Simon Charette Owned by:
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords: 6.0
Cc: Mariusz Felisiak, YashRaj1506 Triage Stage: Someday/Maybe
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

​Per this comment , BaseConstraint._check() should be renamed to check() in Django 6.0 when the deprecation period for BaseConstraint.check (now .condition) ends.

Change History (8)

comment:1 by Tim Graham, 8 months ago

Description: modified (diff)
Keywords: 6.0 added
Summary: Rename BaseConstraint._check to check once the deprecation period → Rename BaseConstraint._check() to check()
Triage Stage: Unreviewed → Someday/Maybe

For past releases, I put the Django version number in the keywords field and used that Trac query (example).

comment:5 by Simon Charette, 7 months ago

To make it clear, this ticket cannot be worked on until Django 6.0 which will remove the deprecation shim for CheckConstraint.check in favor of .condition which will allow BaseConstraint.check to be reclaimed.

comment:6 by Sourav Kumar, 4 months ago

Resolution: → fixed
Status: new → closed

The above issue has been resolved in the below PR.
​https://github.com/django/django/pull/18448

in reply to:  6 ; comment:7 by Mariusz Felisiak, 4 months ago

Resolution: fixed
Status: closed → new

Replying to Sourav6971:

The above issue has been resolved in the below PR.
​https://github.com/django/django/pull/18448

Ticket is fixed when PR is merged. Secondly, as Simon already mentioned, this ticket cannot be worked on until Django 6.0. Please work on "Accepted" tickets, not tickets marked as "Someday/maybe".

in reply to:  7 comment:8 by Sourav Kumar, 4 months ago

So sorry for not paying attention. Got carried away with the excitement of solving my first issue.

Replying to Mariusz Felisiak:

Replying to Sourav6971:

The above issue has been resolved in the below PR.
​https://github.com/django/django/pull/18448

Ticket is fixed when PR is merged. Secondly, as Simon already mentioned, this ticket cannot be worked on until Django 6.0. Please work on "Accepted" tickets, not tickets marked as "Someday/maybe".

comment:9 by Aryan Singh , 2 months ago

Sir, please give this issue to me for solving it.

comment:10 by Simon Charette, 2 months ago

Please a take a minute to read the context of the ticket; this ticket cannot be worked on until Django 6.0

comment:11 by YashRaj1506, 3 weeks ago

Cc: YashRaj1506 added
Note: See TracTickets for help on using tickets.
Back to Top