Opened 15 years ago
Closed 15 years ago
#3534 closed (fixed)
newforms ModelChoiceField should not cache choices
Reported by: | Adrian Holovaty | Owned by: | Adrian Holovaty |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
ModelChoiceField
and ModelMultipleChoiceField
cache the output of their queryset
the first time self.choices
is accessed. This is bad for long-running processes, such as mod_python, because the cache gets stale. Plus, it's bad saving all of those choices in memory. The attached unit tests illustrate the problem.
Attachments (1)
Change History (3)
comment:1 Changed 15 years ago by
Triage Stage: | Unreviewed → Accepted |
---|
Changed 15 years ago by
Attachment: | model_choice_field_cache_tests.patch added |
---|
comment:2 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Unit tests