Opened 11 months ago
Last modified 11 months ago
#35319 assigned Cleanup/optimization
Move the link to add a related object inside the .selector-available column for FilteredSelectMultiple.
Description ¶
This came up during discussion on this PR trying to fix #34643, specifically in this comment.
The patch for #34643 involves allowing the related widget wrapper to span the entire width of the screen, which causes the JavaScript widget for FilteredSelectMultiple to span the entire width of the screen. However, in case the widget has a link to add another object, that link now seems disconnected from the widget, especially on mobile layouts (see attached).
It would improve UX if the link to add a related object is moved to the header of the widget instead of at the end.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To add tests to the patch, then uncheck the "Needs tests" flag on the ticket.
- To write documentation for the patch, then uncheck "Needs documentation" on the ticket.
- To improve the patch as described in the pull request review comments or on this ticket, then uncheck "Patch needs improvement".
If creating a new pull request, include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Change History (7)
by , 11 months ago
Attachment: | filtered-select-multiple-full-width.png added |
---|
by , 11 months ago
Attachment: | filtered-select-multiple-full-width-mobile.png added |
---|
The current position of the add link on mobile, after the patch
by , 11 months ago
Attachment: | filtered-select-multiple-new-add-link-position.png added |
---|
Proposed new location of the add link
comment:1 by , 11 months ago
Keywords: | accessibility added |
---|---|
Owner: | changed from | to
Status: | new → assigned |
Summary: | Move the link to add a related object inside the .selector-available column instead of after the selector widget for FilteredSelectMultiple → Move the link to add a related object inside the .selector-available column for FilteredSelectMultiple. |
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 11 months ago
Needs tests: | set |
---|
comment:4 by , 11 months ago
Needs documentation: | set |
---|---|
Patch needs improvement: | set |
The current position of the add link, after the filtered select widget stretches the full width of the screen