Add test for AdminSite with custom headers.

[Kasun Herath]

Commit ​commit introduced attributes to AdminSite class that can control site header, site title and index title. ​AdminSite

But the corresponding unit test still checks for the default site titles not for the attributes on the site instance. ​https://github.com/django/django/blob/main/tests/admin_views/test_adminsite.py#L41

[Mariusz Felisiak]

Thanks for the ticket, there is no need to adjust existing tests, I'd rather add a new one, e.g.

tests/admin_views/test_adminsite.py

@@ -1 +1 @@
 from django.contrib import admin
 from django.contrib.admin.actions import delete_selected
-from django.contrib.auth.models import User
+from django.contrib.auth.models import Group, User
 from django.test import SimpleTestCase, TestCase, override_settings
 from django.test.client import RequestFactory
 from django.urls import path, reverse
@@ -11 +11 @@
 site.register(User)
 site.register(Article)
 
+
+class CustomAdminSite(admin.AdminSite):
+    site_title = "My title"
+    site_header = "My admin site"
+
+
+custom_site = CustomAdminSite(name="test_custom_adminsite")
+custom_site.register(Group)
+
 urlpatterns = [
     path("test_admin/admin/", site.urls),
+    path("test_custom_admin/admin/", custom_site.urls),
 ]
 
 
@@ -43 +53 @@
         self.assertEqual(ctx["site_url"], "/")
         self.assertIs(ctx["has_permission"], True)
 
+    def test_admin_custom_headers(self):
+        request = self.request_factory.get(reverse("test_custom_adminsite:index"))
+        request.user = self.u1
+        ctx = custom_site.each_context(request)
+        self.assertEqual(ctx["site_title"], "My title")
+        self.assertEqual(ctx["site_header"], "My admin site")
+
     def test_each_context_site_url_with_script_name(self):
         request = self.request_factory.get(
             reverse("test_adminsite:index"), SCRIPT_NAME="/my-script-name/"

For the future, extra test coverage doesn't require a ticket.

[Kasun Herath]

Thanks for the quick feedback! Here is a ​PR with the suggested changes.

[GitHub <noreply@…>]

In f5ed4306:

Fixed #35265 -- Added AdminSite tests for changing titles.