Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#35144 closed Uncategorized (invalid)

Inconsistency in apostrophe symbols of translatable strings. And broken translations

Reported by: Mārtiņš Šulcs Owned by: nobody
Component: Internationalization Version: 5.0
Severity: Normal Keywords:
Cc: Mārtiņš Šulcs Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The usage of apostrophe symbols in source code is inconsistent, sometimes it's (0x2019), and other times it's '(0x27). From what I understand, gettext does not normalize this.
Looking at the translations of contrib.auth, there are several broken keys. For instance:

Message source - [Link](https://github.com/django/django/blob/main/django/contrib/auth/password_validation.py#L266)
Correct id - [Link](https://github.com/django/django/blob/main/django/contrib/auth/locale/lv/LC_MESSAGES/django.po#L270)
Wrong id - [Link](https://github.com/django/django/blob/main/django/contrib/auth/locale/lt/LC_MESSAGES/django.po#L277)

Grepping shows there are other places where is used in translatable strings but this is the place we encountered broken translation.

I'm not familiar with how Transifex operates and whether this should be fixed in the translation. However, the inconsistency in the source doesn't seem ideal.

Change History (4)

comment:1 by Mariusz Felisiak, 10 months ago

Resolution: invalid
Status: newclosed

I'm not familiar with how Transifex operates and whether this should be fixed in the translation.

Yes, this should be fixed in Transifex by translators.

However, the inconsistency in the source doesn't seem ideal.

What kind of inconsistency are you talking about? We put efforts to improve typography of user facing strings everywhere in the source code (check out #30400).

comment:2 by Mariusz Felisiak, 10 months ago

lt contains old strings with ' because no one has translated any new strings in it since 2017.

comment:3 by Mārtiņš Šulcs, 10 months ago

Thanks. So it's supposed to be everywhere. I will see how to report this in Transifex.

Just to understand how this works and what happened. Source messages get changed without updating the keys and that invalidates all the translations in Transifex so they need to be resubmitted?

comment:4 by Mariusz Felisiak, 10 months ago

Source messages are updated on Transifex for each version (so you will find there), however, we don't fetch translations for languages without any new translated strings. That's why there is ' in the source code for many-years untouched translations.

Note: See TracTickets for help on using tickets.
Back to Top