Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#35135 closed Bug (fixed)

FilteredRelation fails when rhs of the condition is a queryset

Reported by: Nicolas Delaby Owned by: Nicolas Delaby
Component: Database layer (models, ORM) Version: 5.0
Severity: Release blocker Keywords:
Cc: Francesco Panico Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is a regression test on the following pr ​https://github.com/django/django/pull/17771

Change History (8)

comment:1 by Mariusz Felisiak, 10 months ago

Cc: Francesco Panico added
Owner: changed from nobody to Nicolas Delaby
Severity: Normal → Release blocker
Status: new → assigned
Triage Stage: Unreviewed → Accepted

Thanks for the report.

comment:3 by Natalia Bidart, 10 months ago

Patch needs improvement: set

comment:4 by Natalia Bidart, 10 months ago

Patch needs improvement: unset

Sorry, I set the "patch needs improvement" flag in the wrong tab, reverting :-)

comment:5 by Mariusz Felisiak, 9 months ago

Patch needs improvement: set

comment:6 by Mariusz Felisiak, 9 months ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 9 months ago

Resolution: → fixed
Status: assigned → closed

In 820c5f1:

Fixed #35135 -- Made FilteredRelation raise ValueError on querysets as rhs.

Regression in 59f475470494ce5b8cbff816b1e5dafcbd10a3a3.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 9 months ago

In a544005:

[5.0.x] Fixed #35135 -- Made FilteredRelation raise ValueError on querysets as rhs.

Regression in 59f475470494ce5b8cbff816b1e5dafcbd10a3a3.

Backport of 820c5f1bacd41713bd30d8b5fefb66752ff15c4c from main

Note: See TracTickets for help on using tickets.
Back to Top