Opened 22 months ago
Last modified 8 weeks ago
#35119 assigned Cleanup/optimization
Unify max_length for EmailValidator and model's and form's EmailField
| Reported by: | jecarr | Owned by: | sgaynetdinov |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Kushagra S, JaeHyuckSa | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | yes |
| Needs tests: | yes | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
As per this discussion, there is consideration to make the max_length values the same for EmailValidator and EmailField
Change History (10)
follow-up: 5 comment:1 by , 22 months ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Version: | 5.0 → dev |
comment:2 by , 22 months ago
| Summary: | Have the same max_length for EmailValidator and EmailField → Unify max_length for EmailValidator and model's and form's EmailField |
|---|
comment:3 by , 22 months ago
| Cc: | added |
|---|---|
| Has patch: | set |
| Owner: | changed from to |
| Status: | new → assigned |
comment:4 by , 22 months ago
| Needs documentation: | set |
|---|---|
| Needs tests: | set |
| Patch needs improvement: | set |
comment:5 by , 22 months ago
Replying to Natalia Bidart:
jecarr would you be interested in pushing this forward?
Thanks Natalia, happy to do so whilst going with your direction on this. Should I start by creating test cases to analyse the different combinations you outlined?
comment:7 by , 22 months ago
Sure, ok - when I wrote my previous comment the PR wasn't linked. I'll leave it to Kushagra S and happy to help if needed.
comment:8 by , 4 months ago
| Owner: | changed from to |
|---|
comment:9 by , 4 months ago
| Cc: | added |
|---|
comment:10 by , 8 weeks ago
| Owner: | changed from to |
|---|
Accepting following ticket:34961#comment:9, where it's suggested that we should unify
max_lengthto be 254 across theEmailValidatorand the form's and model'sEmailField.But before moving forward, I would like us to understand the implications of reducing the
max_lengthfor the validator and form field, and evaluate whether a deprecation warning/process is needed.I think we should make an analysis about how existing code bases could be affected by this change. Ideally we would describe how different combinations of using model's and form's
EmailFieldwould interact with each other when themax_lengthchanges, considering bothModelForms andForms. jecarr would you be interested in pushing this forward?