Opened 5 months ago

Closed 5 months ago

#35064 closed Bug (fixed)

Window.order_by decimal field is broken on SQLite

Reported by: Simon Charette Owned by: Simon Charette
Component: Database layer (models, ORM) Version: 3.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Initially reported ​on the Discord and demonstrated in ​this Django project.

class RankTest(models.Model):
    name = models.CharField(max_length=30)
    category = models.CharField(max_length=30)
    rating = models.DecimalField(max_digits=8, decimal_places=5)

list(
    RankTest.objects.annotate(
        rank=Window(
            expression=Rank(),
            order_by='rating'
        )
    )
)

The solution implemented in #31723 (71d10ca8c90ccc1fd0ccd6683716dd3c3116ae6a) wish addressed the improper of casting for Window.expression caused some problematic one for order_by and likely partition_by as well.

Change History (6)

comment:1 by Mariusz Felisiak, 5 months ago

Triage Stage: Unreviewed → Accepted

comment:2 by Simon Charette, 5 months ago

Owner: changed from nobody to Simon Charette
Status: new → assigned

comment:3 by Simon Charette, 5 months ago

Has patch: set

​PR

Last edited 5 months ago by Mariusz Felisiak (previous) (diff)

comment:4 by Mariusz Felisiak, 5 months ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 5 months ago

In 90d365d8:

Refs #35064 -- Made OrderableAggMixin avoid creating empty OrderByList.

This paves the way for making OrderByList a simple shim over
ExpressionList which requires at least a single item to be provided.

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 5 months ago

Resolution: → fixed
Status: assigned → closed

In e16d0c1:

Fixed #35064 -- Fixed Window(order_by) crash with DecimalFields on SQLite.

This avoids cast of Window(order_by) for DecimalFields on SQLite.

This was achieved by piggy-backing ExpressionList which already
implements a specialized as_sqlite() method to override the inherited
behaviour of Func through SQLiteNumericMixin.

Refs #31723.

Thanks Quoates for the report.

Note: See TracTickets for help on using tickets.
Back to Top