Opened 11 months ago
Last modified 9 months ago
#35058 assigned Cleanup/optimization
Update GDAL integration
Reported by: | David Smith | Owned by: | David Smith |
---|---|---|---|
Component: | GIS | Version: | 4.2 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
During the GDAL 2.x and 3.x releases GDAL has expanded its public entry points, added new features. While one of these new features is curved geometries #34406 I think we should conduct a review and consider if new items should be added to Django. Here's a few specific items to start with:
OGR_G_CoordinateDimension
OGR_G_CoordinateDimension is deprecated in favour of OGR_G_CoordinateDimension()
, OGR_G_Is3D()
and OGR_G_IsMeasured()
.
OGRwkbGeometryType
Support should be added to understand a wider scope of WKT inputs. For example `POINT ZM (1 1 5 60)` is valid but currently results in an error. ( Invalid OGR Integer Type: 3001
).
I think maybe this is because new WKB types are supported see OGRwkbGeometryType : https://gdal.org/doxygen/ogr__core_8h.html and https://github.com/OSGeo/gdal/blob/62c1489feab9312d0468abde0ad13d7b35ce27f7/ogr/ogr_core.h#L529.
This likely needs to be fixed before OGR_G_CoordinateDimension
. (You can't write a test for OGR_G_IsMeasured
without first creating a geometry with a measure)
OGR_G_CreateFromWkbEx
OGR_G_CreateFromWkbEx is added in GDAL 3.3. I think we should prefer this over the existing OGR_G_CreateFromWkb
when available. The difference is the new method supports large (2gb+) inputs. In 3.3+ the old method now raises and error suggesting use of the new method, and was unsupported in previous versions.
Change History (19)
comment:1 by , 11 months ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Type: | Uncategorized → Cleanup/optimization |
comment:5 by , 10 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:6 by , 10 months ago
Has patch: | set |
---|
PR to add support for the "M" dimension to "POINT" geometries.
comment:8 by , 10 months ago
Patch needs improvement: | set |
---|
comment:11 by , 9 months ago
Patch needs improvement: | unset |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
comment:13 by , 9 months ago
Status: | new → assigned |
---|
comment:17 by , 9 months ago
Has patch: | unset |
---|
Agreed, we definitely needs some cleaning there.