DisallowedModelAdminLookup for foreign key to non-AutoField primary key

[Joshua Goodwin]

I have a model whose primary key is not an AutoField, and another model with a foreign key pointing at that:

class Country(models.Model):
    id = models.CharField(max_length=2, primary_key=True)


class Place(models.Model):
    country = models.ForeignKey(Country, models.CASCADE)

And a ModelAdmin with this list_filter:

@admin.register(models.Place)
class PlaceAdmin(admin.ModelAdmin):
    list_filter = ["country"]

Since 45ecd9acca9b36093e274f47b6877a5f79108d9e, filtering places by country in the admin site raises django.contrib.admin.exceptions.DisallowedModelAdminLookup: Filtering by country__id__exact not allowed

[Natalia Bidart]

I can reproduce in latest Django main and I confirm that this is a regression in the reported revision 45ecd9acca9b36093e274f47b6877a5f79108d9e

[Mariusz Felisiak <felisiak.mariusz@…>]

In f80669d:

Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield primary keys.

Thanks Joshua Goodwin for the report.

Regression in 45ecd9acca9b36093e274f47b6877a5f79108d9e.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 454fd50e:

[5.0.x] Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield primary keys.

Thanks Joshua Goodwin for the report.

Regression in 45ecd9acca9b36093e274f47b6877a5f79108d9e.

Backport of f80669d2f5a5f1db9e9b73ca893fefba34f955e7 from main

[Aleksander Vognild Burkow]

Hi.

This seems to have broken django admin url filtering on foreign keys as well. I am on django 5.0.1.

I have a model, PriceGroup with FK to Booking, and when i attempt to filter PriceGroup in django admin on ?booking_id=... in the url i get Error: Filtering by booking not allowed in a small red alert box.

The foreign key being declared as

booking = models.ForeignKey(Booking, null=False, on_delete=models.PROTECT)

and booking having the default primary key that django makes.

[Sarah Boyce]

Hi @aleksanb 👋
Yes, this has been raised here: https://code.djangoproject.com/ticket/35087