#35012 closed Bug (fixed)
Wide fieldset fields are hidden.
Reported by: | James Gillard | Owned by: | Tom Carrick |
---|---|---|---|
Component: | contrib.admin | Version: | 4.2 |
Severity: | Release blocker | Keywords: | |
Cc: | Tom Carrick | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Description (last modified by )
I've traced a change in how one of our fieldsets that contains 3 wide text inputs displays in the admin. The form fields are overflowing the edge of the page. In the 4.2.8-narrow screenshot, the 3rd is initially completely hidden from view. The UI cannot be scrolled but can be tabbed through. Re-adding this removed line of CSS fixes it for me: https://github.com/django/django/commit/bd0ea8c2ba9943ed245771265f55645dc3bfeae8#diff-ec6643f5575f7b320d2f0f6b342a6ff8d3d5b29e305e6d3b45ca115774012f99L27
This was working on 4.2.7, breaks on 4.2.8, and I've tested main also and see the same visual change. I don't understand the full history of this change hence I'm not suggesting a fix.
Attachments (6)
Change History (22)
by , 11 months ago
Attachment: | 4.2.7-wide.png added |
---|
by , 11 months ago
Attachment: | 4.2.7-narrow.png added |
---|
by , 11 months ago
Attachment: | 4.2.8-wide.png added |
---|
by , 11 months ago
Attachment: | 4.2.8-narrow.png added |
---|
comment:1 by , 11 months ago
Description: | modified (diff) |
---|
comment:2 by , 11 months ago
Description: | modified (diff) |
---|
comment:3 by , 11 months ago
comment:5 by , 11 months ago
Thank you James! Could you please provide minimal models.py and admin.py to reproduce the issue?
comment:6 by , 11 months ago
Cc: | added |
---|
by , 11 months ago
by , 11 months ago
comment:7 by , 11 months ago
Here's a zip containing a minimal reproduction, and just the models.py and admin.py files below. The issue is visible with only 2 fields, but I've included 3 as that was what my setup has.
class Foo(models.Model): a = models.CharField(max_length=200) b = models.CharField(max_length=200) c = models.CharField(max_length=200)
@admin.register(Foo) class FooAdmin(admin.ModelAdmin): fieldsets = ( ( None, { "fields": (("a", "b", "c"),), }, ), )
comment:8 by , 11 months ago
Severity: | Normal → Release blocker |
---|---|
Triage Stage: | Unreviewed → Accepted |
Version: | dev → 4.2 |
Thanks for the report! Regression in bd0ea8c2ba9943ed245771265f55645dc3bfeae.
comment:9 by , 11 months ago
Summary: | Admin form visual regression → Wide fieldset fields are hidden. |
---|
comment:10 by , 11 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:11 by , 11 months ago
Has patch: | set |
---|
comment:13 by , 11 months ago
Triage Stage: | Accepted → Ready for checkin |
---|
Hello James, thank you for your report. Could you please try with the latest stable release, 5.0 and let us know how that goes?