#34994 closed Bug (fixed)
Visual regression in admin checkboxes on mobile
Reported by: | Tom Carrick | Owned by: | Tom Carrick |
---|---|---|---|
Component: | contrib.admin | Version: | 4.2 |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Attachments (2)
Change History (22)
by , 12 months ago
Attachment: | admin-checkboxes.png added |
---|
comment:1 by , 12 months ago
Description: | modified (diff) |
---|
comment:2 by , 12 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Triage Stage: | Unreviewed → Accepted |
Type: | Uncategorized → Bug |
comment:4 by , 12 months ago
Triage Stage: | Accepted → Unreviewed |
---|---|
Type: | Bug → Uncategorized |
comment:5 by , 12 months ago
Triage Stage: | Unreviewed → Accepted |
---|---|
Type: | Uncategorized → Bug |
comment:7 by , 12 months ago
Has patch: | set |
---|
follow-up: 9 comment:8 by , 12 months ago
As per my testing, this is a regression in d687febce5868545f99974d2499a91f81a32fef5 not in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.
follow-up: 10 comment:9 by , 12 months ago
Replying to Natalia Bidart:
As per my testing, this is a regression in d687febce5868545f99974d2499a91f81a32fef5 not in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.
Are you sure? I checked with Django 4.2.7 and it's centered, it looks fine in Django 4.1.13.
follow-up: 11 comment:10 by , 12 months ago
Replying to Mariusz Felisiak:
Replying to Natalia Bidart:
As per my testing, this is a regression in d687febce5868545f99974d2499a91f81a32fef5 not in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.
Are you sure? I checked with Django 4.2.7 and it's centered, it looks fine in Django 4.1.13.
Yes, I'm sure. I checked out revno d687febce5868545f99974d2499a91f81a32fef5 and the problem is clearly there, and then I checked out the revno right before it (21757bbdcd6ef31f2a4092fa1bd55dff29214c7a) and the check boxes are OK.
d687febce5868545f99974d2499a91f81a32fef5 was backported to 4.2 in revno 788f7b8100dbef050129bf5c1e0af47e7bc89b28
comment:11 by , 12 months ago
d687febce5868545f99974d2499a91f81a32fef5 was backported to 4.2 in revno 788f7b8100dbef050129bf5c1e0af47e7bc89b28
So it's still a release blocker for Django 4.2.
comment:15 by , 12 months ago
Triage Stage: | Accepted → Ready for checkin |
---|
comment:16 by , 7 months ago
This is still broken for fieldsets with a checkbox plus another field on the same line, like:
class SwitcherAdmin(admin.ModelAdmin): fieldsets = [ ( None, { "fields": [ ("up", "down"), ], }, ), ]
This is due to checkbox-row
being only applied when there’s a single checkbox in the row. I am making a small PR that fixes this issue and another, #35386. Follw on that ticket.
oops, sorry