Visual regression in admin checkboxes on mobile

[Tom Carrick]

I think it may have been intentional, but it looks pretty wrong.

[Tom Carrick]

oops, sorry

[Tom Carrick]

​PR

[Natalia Bidart]

As per my testing, this is a regression in d687febce5868545f99974d2499a91f81a32fef5 not in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

[Mariusz Felisiak]

Replying to Natalia Bidart:

As per my testing, this is a regression in d687febce5868545f99974d2499a91f81a32fef5 not in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Are you sure? I checked with Django 4.2.7 and it's centered, it looks fine in Django 4.1.13.

[Natalia Bidart]

Replying to Mariusz Felisiak:

Replying to Natalia Bidart:

As per my testing, this is a regression in d687febce5868545f99974d2499a91f81a32fef5 not in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Are you sure? I checked with Django 4.2.7 and it's centered, it looks fine in Django 4.1.13.

Yes, I'm sure. I checked out revno d687febce5868545f99974d2499a91f81a32fef5 and the problem is clearly there, and then I checked out the revno right before it (21757bbdcd6ef31f2a4092fa1bd55dff29214c7a) and the check boxes are OK.

d687febce5868545f99974d2499a91f81a32fef5 was backported to 4.2 in revno 788f7b8100dbef050129bf5c1e0af47e7bc89b28

[Mariusz Felisiak]

d687febce5868545f99974d2499a91f81a32fef5 was backported to 4.2 in revno 788f7b8100dbef050129bf5c1e0af47e7bc89b28

So it's still a release blocker for Django 4.2.

[Natalia <124304+nessita@…>]

In a89c715c:

Fixed #34994 -- Fixed checkbox layout in admin's change page for narrow screen widths.

Regression in d687febce5868545f99974d2499a91f81a32fef5.

[Natalia <124304+nessita@…>]

In 4d33816c:

[5.0.x] Fixed #34994 -- Fixed checkbox layout in admin's change page for narrow screen widths.

Regression in d687febce5868545f99974d2499a91f81a32fef5.

Backport of a89c715c3bcf7ab1a90747cf8658ebce6304b6e4 from main

[Natalia <124304+nessita@…>]

In bac9e94:

[4.2.x] Fixed #34994 -- Fixed checkbox layout in admin's change page for narrow screen widths.

Regression in d687febce5868545f99974d2499a91f81a32fef5.

Backport of a89c715c3bcf7ab1a90747cf8658ebce6304b6e4 from main

[Adam Johnson]

two checkboxes centred

[Adam Johnson]

This is still broken for fieldsets with a checkbox plus another field on the same line, like:

class SwitcherAdmin(admin.ModelAdmin):
    fieldsets = [
        (
            None,
            {
                "fields": [
                    ("up", "down"),
                ],
            },
        ),
    ]

This is due to checkbox-row being only applied when there’s a single checkbox in the row. I am making a small PR that fixes this issue and another, #35386. Follw on that ticket.

[Sarah Boyce <42296566+sarahboyce@…>]

In bdd76c4:

Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class unconditionally in Admin.

[Sarah Boyce <42296566+sarahboyce@…>]

In ffcf6607:

[5.0.x] Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class unconditionally in Admin.

Backport of bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16 from main.

[Sarah Boyce <42296566+sarahboyce@…>]

In 0fc8326:

[4.2.x] Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class unconditionally in Admin.

Backport of bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16 from main.

[Sarah Boyce <42296566+sarahboyce@…>]

In 256f719:

[4.2.x] Reverted "Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class unconditionally in Admin."

This reverts commit 0fc832676cd585fa420d583937b5b2318bc2c629.

[Sarah Boyce <42296566+sarahboyce@…>]

In a42a2fa:

[5.0.x] Reverted "Fixed #34994, Fixed #35386 -- Applied checkbox-row CSS class unconditionally in Admin."

This reverts commit ffcf66071158ed3b5541ed13b4c7381240d1b310.