Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#34991 closed Bug (fixed)

Wrong layout of pagination buttons with editable list in the admin.

Reported by: Rafał Safin Owned by: Tom Carrick
Component: contrib.admin Version: 4.2
Severity: Release blocker Keywords: CSS, admin
Cc: Alexander Freyr Lúðvíksson, Tom Carrick, Thibaud Colas Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

Hello, there is a small bug in Admin panel pagination css style.

To reproduce, one must register model in Admin panel with at least one item in list_editable attribute (so the "Save" button will show up). It seems .this-page class has vertical align top and because button is large, it doesn't fit. Fix is to use vertical-align: middle, as far as i can see, this is the only place where this class is used.

currently:
​https://user-images.githubusercontent.com/51059348/285057879-100f638f-5b6a-4ec7-afc5-588064cc9a84.png

after fix:
​https://user-images.githubusercontent.com/51059348/285059957-61c41c7f-0784-49f0-bdd8-16d5d6f263c2.png

Attachments (3)

Screenshot from 2023-11-22 23-27-10.png​ (29.7 KB ) - added by Rafał Safin 13 months ago.
django42.png​ (23.7 KB ) - added by Mariusz Felisiak 13 months ago.
django41.png​ (23.8 KB ) - added by Mariusz Felisiak 13 months ago.

Download all attachments as: .zip

Change History (13)

by Rafał Safin, 13 months ago

Attachment: Screenshot from 2023-11-22 23-27-10.png​ added

comment:1 by Rafał Safin, 13 months ago

Has patch: set
Owner: changed from nobody to Rafał Safin
Status: new → assigned

​https://github.com/django/django/pull/17513

comment:2 by Mariusz Felisiak, 13 months ago

Cc: Alexander Freyr Lúðvíksson Tom Carrick Thibaud Colas added
Patch needs improvement: set
Severity: Normal → Release blocker
Summary: Small admin panel css bug in pagination styles → Wrong layout of pagination buttons with editable list in the admin.
Triage Stage: Unreviewed → Accepted
Version: dev → 4.2

Thanks for the report. This is a visual regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07. I don't think that fixing an alignment of this-page is enough, we should restore the pre-Django 4.2 look:


now:


Last edited 13 months ago by Mariusz Felisiak (previous) (diff)

by Mariusz Felisiak, 13 months ago

Attachment: django42.png​ added

by Mariusz Felisiak, 13 months ago

Attachment: django41.png​ added

comment:3 by Tom Carrick, 13 months ago

Owner: changed from Rafał Safin to Tom Carrick

I'll take a look, this seems reasonable.

comment:4 by Tom Carrick, 13 months ago

Patch needs improvement: unset

​PR

comment:5 by Tom Carrick, 13 months ago

Rafał, not sure if you were still working on this. If so, sorry!

comment:6 by Natalia Bidart, 13 months ago

Triage Stage: Accepted → Ready for checkin

comment:7 by Natalia <124304+nessita@…>, 13 months ago

Resolution: → fixed
Status: assigned → closed

In 4eb9c3d9:

Fixed #34991 -- Fixed pagination links and input layout in admin's change list page when using list_editable.

Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Thanks Tom Carrick for the report and fix.

comment:8 by Natalia <124304+nessita@…>, 13 months ago

In 3d943c4f:

[4.2.x] Fixed #34991 -- Fixed pagination links and input layout in admin's change list page when using list_editable.

Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Thanks Tom Carrick for the report and fix.

Backport of 4eb9c3d90aff55182151b6be0122f7d0b28832fd from main

comment:9 by Natalia <124304+nessita@…>, 13 months ago

In 15d49c8:

[5.0.x] Fixed #34991 -- Fixed pagination links and input layout in admin's change list page when using list_editable.

Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Thanks Tom Carrick for the report and fix.

Backport of 4eb9c3d90aff55182151b6be0122f7d0b28832fd from main

comment:10 by Rafał Safin, 13 months ago

Thank you for valuable input Mariusz.

No, I didn't work more on it @Tom, as pointed out (closed PR), I didn't have the context on how this should be fixed properly and what is desired look, so after reading Mariusz's comment, I decided that someone else would probably have better idea :D

Thanks for the fix everyone! :P ;)

Last edited 13 months ago by Rafał Safin (previous) (diff)
Note: See TracTickets for help on using tickets.
Back to Top