#34991 closed Bug (fixed)
Wrong layout of pagination buttons with editable list in the admin.
| Reported by: | Rafał Safin | Owned by: | Tom Carrick |
|---|---|---|---|
| Component: | contrib.admin | Version: | 4.2 |
| Severity: | Release blocker | Keywords: | CSS, admin |
| Cc: | Alexander Freyr Lúðvíksson, Tom Carrick, Thibaud Colas | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | yes |
Description
Hello, there is a small bug in Admin panel pagination css style.
To reproduce, one must register model in Admin panel with at least one item in list_editable attribute (so the "Save" button will show up). It seems .this-page class has vertical align top and because button is large, it doesn't fit. Fix is to use vertical-align: middle, as far as i can see, this is the only place where this class is used.
Attachments (3)
Change History (13)
by , 6 months ago
| Attachment: | Screenshot from 2023-11-22 23-27-10.png added |
|---|
comment:1 by , 6 months ago
| Has patch: | set |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 6 months ago
| Cc: | added |
|---|---|
| Patch needs improvement: | set |
| Severity: | Normal → Release blocker |
| Summary: | Small admin panel css bug in pagination styles → Wrong layout of pagination buttons with editable list in the admin. |
| Triage Stage: | Unreviewed → Accepted |
| Version: | dev → 4.2 |
Thanks for the report. This is a visual regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07. I don't think that fixing an alignment of this-page is enough, we should restore the pre-Django 4.2 look:
now:
by , 6 months ago
| Attachment: | django42.png added |
|---|
by , 6 months ago
| Attachment: | django41.png added |
|---|
comment:6 by , 6 months ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:10 by , 5 months ago
Thank you for valuable input Mariusz.
No, I didn't work more on it @Tom, as pointed out (closed PR), I didn't have the context on how this should be fixed properly and what is desired look, so after reading Mariusz's comment, I decided that someone else would probably have better idea :D
Thanks for the fix everyone! :P ;)
https://github.com/django/django/pull/17513