Opened 12 months ago
Closed 8 months ago
#34977 closed Cleanup/optimization (fixed)
Turn link to change password form in admin user change form into a button
Reported by: | Fabian Braun | Owned by: | Fabian Braun |
---|---|---|---|
Component: | contrib.auth | Version: | dev |
Severity: | Normal | Keywords: | accessibility |
Cc: | Thibaud Colas, Tom Carrick, Sarah Abderemane | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
Currently, to change a user's password the admin user must got to the change user form, find the password field and click a link in its help text.
For better user guidance and accessibility, I suggest turning this link into a button:
As David Smith pointed out, links in help texts are not read by screen readers:
"Do not include links within hint text. While screen readers will read out the link text when describing the field, they will not tell users that the text is a link." (https://design-system.service.gov.uk/components/text-input/#hint-text).
I'll be happy to provide a patch.
Attachments (2)
Change History (18)
by , 12 months ago
Attachment: | password-link.jpg added |
---|
comment:1 by , 12 months ago
Description: | modified (diff) |
---|
by , 12 months ago
Attachment: | password-button.png added |
---|
Potential new change or (in this case) set password button.
comment:2 by , 12 months ago
Description: | modified (diff) |
---|
comment:3 by , 12 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 12 months ago
Has patch: | set |
---|
comment:5 by , 12 months ago
Owner: | changed from | to
---|
comment:6 by , 12 months ago
Keywords: | accessibility added |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:7 by , 11 months ago
I added some review comments proposing a slightly different approach: instead of having either a link or a button *in* the help text, I would like that we separate the help text legend from the "convenience shortcut" to hint the admin user where they can act regarding the password.
I'd like the accessibility team's input, I attached a possible diff to the linked PR.
comment:8 by , 11 months ago
Cc: | added |
---|
comment:10 by , 10 months ago
Replying to Abhii67534:
I would like to work on this issue :)
Thank you for your interest in helping, but there is already a submitted PR solving this issue, we are just waiting on some specific feedback.
comment:11 by , 9 months ago
Patch needs improvement: | set |
---|
Setting as patch needs improvement until conflicts are solved and the PR is reviewable again.
comment:12 by , 8 months ago
Patch needs improvement: | unset |
---|
comment:13 by , 8 months ago
Needs documentation: | set |
---|---|
Patch needs improvement: | set |
Version: | 4.2 → dev |
comment:14 by , 8 months ago
Needs documentation: | unset |
---|---|
Patch needs improvement: | unset |
comment:15 by , 8 months ago
Triage Stage: | Accepted → Ready for checkin |
---|
Current link to change password form