Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#34958 closed Bug (fixed)

Intermittent `messages_tests.tests.TestLevelTags.test_lazy` test failure

Reported by: bcail Owned by: Natalia Bidart
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I get following test failure sometimes (it's happened on py3.11, py3.12, and py3.13a1). Seems to be some kind of race condition.

======================================================================
FAIL: test_lazy (messages_tests.tests.TestLevelTags.test_lazy)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 58, in testPartExecutor
    yield
  File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 634, in run
    self._callTestMethod(testMethod)
    ^^^^^^^^^^^^^^^^^
  File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 589, in _callTestMethod
    if method() is not None:
    ^^^^^^^^^^^^^^^^^
  File "/opt/local/src/django/tests/messages_tests/tests.py", line 73, in test_lazy
    self.assertEqual(base.LEVEL_TAGS[constants.ERROR], "bad")
    ^^^^^^^^^^^^^^^^^
  File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 885, in assertEqual
    assertion_func(first, second, msg=msg)
    ^^^^^^^^^^^^^^^^^
  File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 1251, in assertMultiLineEqual
    self.fail(self._formatMessage(msg, standardMsg))
    ^^^^^^^^^^^^^^^^^
  File "/opt/python-3.12.0/lib/python3.12/unittest/case.py", line 715, in fail
    raise self.failureException(msg)
    ^^^^^^^^^^^^^^^^^
AssertionError: 'error' != 'bad'
- error
+ bad

Change History (10)

comment:1 by bcail, 11 months ago

Version: 4.2dev

comment:2 by Mariusz Felisiak, 11 months ago

Component: UncategorizedCore (Other)
Resolution: worksforme
Status: newclosed
Type: UncategorizedBug

Thanks for this report, however, I cannot reproduce the failure in any way (Python 3.10, 3.12, 3.13),

comment:3 by bcail, 11 months ago

More info: I'm on Linux. So far, I've only reproduced the issue running the tests with 12 or more parallel processes.

comment:4 by Natalia Bidart, 11 months ago

Component: Core (Other)contrib.messages
Resolution: worksforme
Status: closednew
Triage Stage: UnreviewedAccepted

Accepting since we got the same failure in our CI logs:

Started by upstream project "main-random" build number 124
originally caused by:
 Started by an SCM change
Running as SYSTEM
Building remotely on focal1 (oracle focal focal-pr) in workspace /home/jenkins/workspace/main-random/database/spatialite/label/focal/python/python3.11
The recommended git tool is: NONE
No credentials specified
Cloning the remote Git repository
Using shallow clone with depth 50
Avoid fetching tags
Honoring refspec on initial clone
Cloning repository https://github.com/django/django.git
 > git init /home/jenkins/workspace/main-random/database/spatialite/label/focal/python/python3.11 # timeout=10
Fetching upstream changes from https://github.com/django/django.git
 > git --version # timeout=10
 > git --version # 'git version 2.25.1'
 > git fetch --no-tags --force --progress --depth=50 -- https://github.com/django/django.git +refs/heads/main:refs/remotes/origin/main # timeout=10
 > git config remote.origin.url https://github.com/django/django.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/main:refs/remotes/origin/main # timeout=10
Avoid second fetch
Checking out Revision f7389c4b07ceeb036436e065898e411b247bca78 (origin/main)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f7389c4b07ceeb036436e065898e411b247bca78 # timeout=10
Commit message: "Fixed #34457 -- Restored output for makemigrations --check."
 > git rev-list --no-walk 797957fb48f63760442d3d4c8985fd94f8602d5e # timeout=10
[python3.11] $ /bin/sh -xe /tmp/jenkins9896387767571950455.sh
+ export EXTRA_RUNTESTS_ARGS=--shuffle
+ git clean -fqdx
+ cd tests
+ cp -r /home/jenkins/djangodata/apt-pin /home/jenkins/djangodata/oracle19.env /home/jenkins/djangodata/oragis19.env /home/jenkins/djangodata/runtests_jenkins.sh /home/jenkins/djangodata/test_mysql.py /home/jenkins/djangodata/test_mysql_gis.py /home/jenkins/djangodata/test_oracle19.py /home/jenkins/djangodata/test_oracle19_host.py /home/jenkins/djangodata/test_oragis19.py /home/jenkins/djangodata/test_postgis.py /home/jenkins/djangodata/test_postgres.py /home/jenkins/djangodata/test_spatialite.py /home/jenkins/djangodata/test_sqlite3.py .
+ sh runtests_jenkins.sh
...
Using shuffle seed: 5354051979 (generated)
Creating test database for alias 'default' ('file:memorydb_default?mode=memory&cache=shared')...
Found 17253 test(s).
...
  test_lazy (messages_tests.tests.TestLevelTags.test_lazy) ... FAIL (0.002s)
...
======================================================================
FAIL [0.002s]: test_lazy (messages_tests.tests.TestLevelTags.test_lazy)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/workspace/main-random/database/spatialite/label/focal/python/python3.11/tests/messages_tests/tests.py", line 73, in test_lazy
    self.assertEqual(base.LEVEL_TAGS[constants.ERROR], "bad")
AssertionError: 'error' != 'bad'
- error
+ bad


----------------------------------------------------------------------
Ran 17251 tests in 1406.234s

FAILED (failures=1, skipped=1139, expected failures=5)

comment:5 by Natalia Bidart, 11 months ago

Owner: changed from nobody to Natalia Bidart
Status: newassigned

comment:6 by Mariusz Felisiak, 11 months ago

Component: contrib.messagesCore (Other)

comment:7 by Natalia Bidart, 11 months ago

Has patch: set

comment:8 by Jacob Walls, 11 months ago

Triage Stage: AcceptedReady for checkin

comment:9 by GitHub <noreply@…>, 11 months ago

Resolution: fixed
Status: assignedclosed

In 1b56b24:

Fixed #34958 -- Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy.

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 11 months ago

In 7a21ea5:

[5.0.x] Fixed #34958 -- Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy.

Backport of 1b56b24f81a2e64b4bd3059abad9b6fd0c801c66 from main

Note: See TracTickets for help on using tickets.
Back to Top