Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#34932 closed Bug (fixed)

Setting deterministic Postgres collations incorrectly disallows use of varchar_pattern_ops and text_pattern_ops

Reported by: Tom Carrick Owned by: Tom Carrick
Component: Migrations Version: 4.2
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description


Change History (7)

comment:1 by Tom Carrick, 2 years ago

Owner: changed from nobody to Tom Carrick

comment:2 by Mariusz Felisiak, 2 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

Thanks for the report. We should be able to skipped varchar_pattern_ops/text_pattern_ops index creation only for non-deterministic collations by introspecting pg_collation.collisdeterministic.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and 8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

comment:3 by Tom Carrick, 2 years ago

Has patch: set

​PR

comment:4 by Mariusz Felisiak, 2 years ago

Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In 34b41176:

Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In 6028352:

[5.0.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

Backport of 34b411762b50883d768d7b67e0a158ec39da8b09 from main

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

In 109f39a3:

[4.2.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.

Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

Backport of 34b411762b50883d768d7b67e0a158ec39da8b09 from main.

Note: See TracTickets for help on using tickets.
Back to Top