Opened 4 months ago

Closed 3 months ago

#34919 closed Bug (fixed)

Missing scope attribute in admin doc table headers.

Reported by: Louis-Cloud Owned by: jed212
Component: contrib.admindocs Version: 4.2
Severity: Normal Keywords: table, scope, screenreader, accessibility
Cc: Thibaud Colas, Sarah Abderemane, Tom Carrick Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Louis-Cloud)

There are a number of tables throughout Django's admin docs that are lacking the scope attribute. Having this attribute in the table headers makes table navigation easier for a screen reader user.

Acceptance Criteria

  • All table column header (th) needs to have a scope = "col" attribute.
  • All table row headers (first column) should have a scope = "row" attribute

Relevant Files:

  • django/contrib/admindocs/templates/admin_doc/model_detail.html
  • django/contrib/admindocs/templates/admin_doc/model_index.html

For more information

Change History (11)

comment:1 by Louis-Cloud, 4 months ago

Description: modified (diff)

comment:2 by Louis-Cloud, 4 months ago

Description: modified (diff)

comment:3 by Louis-Cloud, 4 months ago

Description: modified (diff)

comment:4 by Mariusz Felisiak, 4 months ago

Cc: Thibaud Colas Sarah Abderemane Tom Carrick added
Keywords: accessibility added

comment:5 by Mariusz Felisiak, 4 months ago

Summary: Missing scope attribute in admin doc table headersMissing scope attribute in admin doc table headers.
Triage Stage: UnreviewedAccepted

comment:6 by jed212, 4 months ago

Owner: changed from Louis-Cloud to jed212

comment:7 by jed212, 4 months ago

Has patch: set

comment:8 by Mariusz Felisiak, 4 months ago

Needs tests: set

comment:9 by Mariusz Felisiak, 3 months ago

Easy pickings: set
Patch needs improvement: set

comment:10 by Mariusz Felisiak, 3 months ago

Needs tests: unset
Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:11 by Mariusz Felisiak <felisiak.mariusz@…>, 3 months ago

Resolution: fixed
Status: assignedclosed

In bdf30b95:

Fixed #34919 -- Added scope attribute to admindocs model templates.

Note: See TracTickets for help on using tickets.
Back to Top