Opened 4 months ago

Closed 2 months ago

#34909 closed Bug (fixed)

Accessible names for Add / Change buttons in Django Admin

Reported by: Eliana Rosselli Owned by: Eliana Rosselli
Component: contrib.admin Version: 4.2
Severity: Normal Keywords: accessibility accessible name ux
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

In the Django Admin home screen, all "Add" and "Change" buttons have the same accesible name ("Add" and "Change"), which may be confusing for users with screen readers. This was checked with the Accessibility Insights for the Web extension.

Changing the accessible names to "Add <model-name>" and "Change <model-name>" might be clearer for users with screen readers, but could make it confusing for users using voiceover trying to reference the buttons by their visible names (Add / Change).

Change History (8)

comment:1 by Thibaud Colas, 4 months ago

Component: Uncategorizedcontrib.admin
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

Thank you for the report @Eliana Rosselli! This is a tricky one. As we dicussed there is the risk to do something that works better for some users, but potentially at the expense of others. This article comes to mind: Voice Control Usability Considerations For Partially Visually Hidden Link Names.

There is clearly room for improvement here so I will accept the ticket now – but we need a fair bit of research before deciding what to do about this. My hunch is that an aria-describedby might help, but I’d like to see ourselves reviewing other patterns.

comment:2 by Eliana Rosselli, 4 months ago

Owner: changed from nobody to Eliana Rosselli
Status: newassigned

comment:3 by Mariusz Felisiak, 4 months ago

Has patch: set
Patch needs improvement: set

comment:4 by Natalia Bidart, 4 months ago

Needs tests: set

comment:5 by Eliana Rosselli, 4 months ago

Needs tests: unset
Patch needs improvement: unset

comment:6 by Mariusz Felisiak, 2 months ago

Triage Stage: AcceptedReady for checkin

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 2 months ago

In 5b885106:

Refs #34909 -- Made cosmetic edits to admin navigation template.

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 2 months ago

Resolution: fixed
Status: assignedclosed

In c83c639:

Fixed #34909 -- Associated links in admin navigation sidebar with row descriptions.

This adds aria-describedby attribute to the models' links in the admin
navigation sidebar.

Thanks Thibaud Colas for the review.

Co-authored-by: Dara Silvera <dsilvera@…>

Note: See TracTickets for help on using tickets.
Back to Top