Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3490 closed (fixed)

[patch] Passing an iterable as choices to newforms. ChoiceField breaks.

Reported by: Chris.Wesseling@… Owned by: adrian
Component: Forms Version: master
Severity: Keywords: newforms ChoiceField iterable choices
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Passing a Generator as choices breaks printing the form twice as well as validating passed data.

Attachments (1)

ChoiceField_iterable_choices_fix.patch (2.2 KB) - added by Chris.Wesseling@… 7 years ago.
Fixes ChoiceField(choices=( some generator )) bug.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Chris.Wesseling@…

Fixes ChoiceField(choices=( some generator )) bug.

comment:1 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [4549]) Fixed #3490 -- Fixed issue with newforms ChoiceField and generators as choices. Thanksfor the patch, Chris.Wesseling@…

comment:2 Changed 7 years ago by Chris.Wesseling@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

NP, thanks for the fast incorporation.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.