Opened 14 months ago
Closed 14 months ago
#34862 closed Cleanup/optimization (duplicate)
For clarity, the `password_reset_email.html` template should have `.txt` extension
Reported by: | Curtis Maloney | Owned by: | David Sanders |
---|---|---|---|
Component: | contrib.auth | Version: | 4.2 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The plain text body of a PasswordResetView email currently uses a .html
extension.
The general guide on file extensions for templates is to hint at their content type, and this recently confused a coworker into thinking it was the HTML body of the email.
A possible transition solution would be to default to a list, since render_to_string
already supports finding first match.
Change History (5)
comment:1 by , 14 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 14 months ago
Type: | Bug → Cleanup/optimization |
---|
comment:3 by , 14 months ago
Has patch: | set |
---|---|
Needs documentation: | set |
Owner: | changed from | to
Patch needs improvement: | set |
Status: | new → assigned |
comment:4 by , 14 months ago
Needs documentation: | unset |
---|---|
Patch needs improvement: | unset |
comment:5 by , 14 months ago
Resolution: | → duplicate |
---|---|
Status: | assigned → closed |
Triage Stage: | Accepted → Unreviewed |
Duplicate of #30837.
Note:
See TracTickets
for help on using tickets.
Thanks FunkyBob 👍
This is consistent with other text based templates.