#34788 closed Cleanup/optimization (fixed)
Correct NUMBER_GROUPING in Japan.
| Reported by: | tell-k | Owned by: | nobody |
|---|---|---|---|
| Component: | Internationalization | Version: | 4.2 |
| Severity: | Normal | Keywords: | number grouping, format, japanese |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I want to update django/conf/locale/en/formats.py since the general NUMBER_GROUPING in Japan is 3.
Attachments (1)
Change History (7)
by , 9 months ago
| Attachment: | ja_formats.patch added |
|---|
comment:1 by , 9 months ago
| Component: | Uncategorized → Internationalization |
|---|---|
| Has patch: | unset |
| Summary: | Set the general NUMBER_GROUPING in Japan. → Correct NUMBER_GROUPING in Japan. |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
Thanks, seems good. Would you like to prepare a patch (via GitHub PR)? Do you have a frien who can confirm this change?
comment:2 by , 9 months ago
Hi. I am a Japanese dev who has contributed to Django in the past.
We always write numbers in the style of 100,000.
Many Japanese people set NUMBER_GROUPING manually to use intcomma.
comment:3 by , 9 months ago
+1
In Japan, the public documents from the government are used the style of 100,000.
https://www.bunka.go.jp/seisaku/bunkashingikai/kokugo/hokoku/pdf/93098001_01.pdf
This document specify the style of public documentation.
p17 I-4 数字の使い方
イ 大きな数は、三桁ごとにコンマで区切る
四桁以上の数は三桁ごとにコンマで区切って書く。
例）5,000 62,250 円 1,254,372 人
comment:4 by , 9 months ago
| Has patch: | set |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Hiroki, Shinya, thanks for your confirmation.
Set NUMBER_GROUPING = 3