Creating apps with certain names causes manage.py to stop working

[svant]

manage.py should not allow creating an app with a certain name when that could break manage.py itself.

after doing manage.py startapp site I got the following error when trying to do something with manage.py

Traceback (most recent call last):
  File "path\manage.py", line 2, in ?
    from django.core.management import execute_manager
ImportError: No module named django.core.management

[frankie@…]

Against [4485]

[frankie@…]

Oopsie, typo

[Malcolm Tredinnick]

(Only triagers and committers should move tickets between stages, please.)

I think we need to think about how far we want to go here. Do we put every standard Python module in the list? If not, why do we only put some in?

I'm probably -1 on this idea at the moment, because it's so hard to draw the line and not naming your modeuls after standard Python modules is not a Django-specific requirement.

[frankie@…]

Oops, is triage limited to an exclusive bunch or am I just excluded from triage because of doing the patch?

Anyway, yeah. I agree. As far as I can see there are too solutions:

1. Don't do any checking. This is fair enough, but in this case project names should not be checked either.

2. Make checking more dynamic. As in eval() it and if it comes out as anything but NameError say it's invalid.

[frankie@…]

This patch check for invalid project and app names in the way previously mentioned.

[Simon G. <dev@…>]

#4850 is a related issue.

[Malcolm Tredinnick]

The problem with this is it's a false sense of security. It doesn't prevent you creating a problem later without knowing what went wrong. You always need to be aware of name collisions and we can't really protect people from that.