Opened 2 years ago

Closed 2 years ago

#34621 closed Bug (fixed)

Django admin site name shouldn’t be an h1

Reported by: Thibaud Colas Owned by: Howard Cox
Component: contrib.admin Version: 4.2
Severity: Normal Keywords: accessibility, screen reader
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

In the Django admin header, the site name ("Django administration" by default) is currently set up as an h1 tag. This is problematic for screen reader users because they use headings to navigate – having two h1 is confusing, and the one in the header isn’t particularly helpful since it’s the same on all pages.

It’d be better if this site name used a p or div tag. This switch will also require rewriting the styles so they still work with the new tag.

Change History (6)

comment:1 by Thibaud Colas, 2 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Mariusz Felisiak, 2 years ago

Agreed.

For the future, please don't accept you're own tickets.

comment:3 by Howard Cox, 2 years ago

​PR

comment:4 by Mariusz Felisiak, 2 years ago

Has patch: set
Needs documentation: set

comment:5 by Mariusz Felisiak, 2 years ago

Needs documentation: unset
Triage Stage: Accepted → Ready for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 2 years ago

Resolution: → fixed
Status: assigned → closed

In cd413bd7:

Fixed #34621 -- Made admin site header render in <div> tag.

This was problematic for screen reader users because they use headings
to navigate. Having two <h1> is confusing, and the one in the header
wasn’t particularly helpful since it’s the same on all pages.

Note: See TracTickets for help on using tickets.
Back to Top