Opened 2 years ago
Closed 2 years ago
#34616 closed Cleanup/optimization (fixed)
Incorrect code example in 5.0 release notes
| Reported by: | David Smith | Owned by: | Christopher Cave-Ayland |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
The 5.0 release notes have a code example of a form and its fields being written in Django Template Language.
However the example shows field.label being used. This would give the field's label this world be "name", in the line linked below.
Instead I believe this example should use field.label_tag which would give <label ...>name:</label>. This is closer to what the template is actually doing.
https://github.com/django/django/blob/main/docs/releases/5.0.txt#L62
https://github.com/django/django/blob/main/django/forms/templates/django/forms/field.html#L5
Change History (5)
comment:1 by , 2 years ago
| Component: | Uncategorized → Documentation |
|---|---|
| Easy pickings: | set |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Bug |
comment:2 by , 2 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 2 years ago
| Type: | Bug → Cleanup/optimization |
|---|---|
| Version: | 4.2 → dev |
comment:4 by , 2 years ago
| Has patch: | set |
|---|---|
| Owner: | changed from to |
Note:
See TracTickets
for help on using tickets.
https://github.com/django/django/pull/16912