DatabaseWrapper should pass through args and kwargs to underlying database adapter

[Jack Moffitt <metajack@…>]

Currently the DatabaseWrapper (at least for the postgresql) does not pass args and kwargs for cursor() calls to the underlying database adapter. This makes it impossible to use the adapter fully at the low level. For example, to use dict cursors in psycopg2 you have to pass a different cursor factory via the cursor_factory keyword argument to cursor(). The attached patch passes through args and kwargs for cursor() calls.

[Jack Moffitt <metajack@…>]

pass through args and kwargs for calls to cursor()

[Marc Fargas <telenieko@…>]

​being discussed here

[eliott@…]

Any update on this?
Would be very nice to not have to patch my working copy of the django libs, and so I can be more sure it will work on other installs.

[Jacob]

A good idea -- orthogonal to DATABASE_OPTIONS added some time back -- but this needs to be done in a cross-database way, not just for one backend.

[Jack Moffitt <metajack@…>]

Sure, a cross database way would just be to apply the same style patch to other backends, no? Why not file a seperate bug for that project to replicate this patch on the other backends, instead of holding this one up until a perfect solution arrives.

[Malcolm Tredinnick]

The current patch still needs documentation (topics/db/sql.txt would seem to be a reasonable location) and doesn't patch the SQLite or Oracle backends. Also, it should be possible to test this, at least in a backend-specific fashion (checking settings.DATABASE_ENGINE in the test). I'd like to see a test for at least one backend.

Whoever fixes it should have a "reasonable attempt" at the Oracle backend -- I realise testing that can be tricky, but we can get confirmation of correctness from other people before applying.

[Manel Clos]

Checked with Django 1.2.3, works ok. Just one addition to the patch:

db/backends/__init__.py:73

    def cursor(self, *args, **kwargs):
        from django.conf import settings
        cursor = self._cursor(*args, **kwargs)

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Olivier Tabone]

please comment on ​PR

[Asif Saifuddin Auvi]

I am unsure where to put the doc changes, so asked in the pr but did not get any response. after adding docs and release note I will squash commits

[Tim Graham]

comment:9 contains a suggestion about the documentation. The content is more important; the location can easily be changed if needed.

[Asif Saifuddin Auvi]

needs retarget 3.2 and add missing docs :( hopefully, make this happen this time!