Opened 20 months ago

Closed 16 months ago

Last modified 4 months ago

#34547 closed Cleanup/optimization (fixed)

Deprecate DatabaseOperations.field_cast_sql().

Reported by: Mariusz Felisiak Owned by: David Smith
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: David Sanders Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

DatabaseOperations.field_cast_sql() is noop for all builtin backends since 1586a09b7949bbb7b0d84cb74ce1cadc25cbb355. I think we can deprecate it in favor of DatabaseOperations.lookup_cast() which is more flexible.

Change History (6)

comment:1 by Natalia Bidart, 20 months ago

Triage Stage: Unreviewed → Accepted

Accepting following the PR ​comments.

comment:2 by David Smith, 17 months ago

Owner: changed from nobody to David Smith
Status: new → assigned

comment:3 by Mariusz Felisiak, 16 months ago

Has patch: set
Patch needs improvement: set

​PR

comment:4 by Mariusz Felisiak, 16 months ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 16 months ago

Resolution: → fixed
Status: assigned → closed

In 27b399d:

Fixed #34547 -- Deprecated DatabaseOperations.field_cast_sql().

comment:6 by nessita <124304+nessita@…>, 4 months ago

In a69f895d:

Refs #34547 -- Adjusted deprecation warning stacklevel in DatabaseOperations.field_cast_sql().

Note: See TracTickets for help on using tickets.
Back to Top