dbshell management command can crash if DATABASES["name"] is a PosixPath

[Jan Pieter Waagmeester]

With a sqlite database configured in settings.py like this:

DATABASES = {
    "default": {
        "ENGINE": "django.db.backends.sqlite3",
        "NAME": BASE_DIR / "db.sqlite3",
    }
}

exiting ./manage.py dbshell using Control - d sometimes results in this exception:

Traceback (most recent call last):
  File "/home/ubuntu/virtualenv/lib/python3.11/site-packages/django/core/management/commands/dbshell.py", line 30, in handle
    connection.client.runshell(options["parameters"])
  File "/home/ubuntu/virtualenv/lib/python3.11/site-packages/django/db/backends/base/client.py", line 28, in runshell
    subprocess.run(args, env=env, check=True)
  File "/usr/lib/python3.11/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['sqlite3', PosixPath('/home/ubuntu/planning-poker/db.sqlite3')]' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/planning-poker/./manage.py", line 30, in <module>
    main()
  File "/home/ubuntu/planning-poker/./manage.py", line 26, in main
    execute_from_command_line(sys.argv)
  File "/home/ubuntu/virtualenv/lib/python3.11/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
    utility.execute()
  File "/home/ubuntu/virtualenv/lib/python3.11/site-packages/django/core/management/__init__.py", line 436, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/ubuntu/virtualenv/lib/python3.11/site-packages/django/core/management/base.py", line 412, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/ubuntu/virtualenv/lib/python3.11/site-packages/django/core/management/base.py", line 458, in execute
    output = self.handle(*args, **options)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/virtualenv/lib/python3.11/site-packages/django/core/management/commands/dbshell.py", line 44, in handle
    " ".join(e.cmd),
    ^^^^^^^^^^^^^^^
TypeError: sequence item 1: expected str instance, PosixPath found

coercing each item in e.cmd to string should fix this.

[David Sanders]

felix will update the name to be specific to the error

[David Sanders]

PR: ​https://github.com/django/django/pull/16824

[Mariusz Felisiak]

Regression in 5b884d45ac5b76234eca614d90c83b347294c332.

[Mariusz Felisiak <felisiak.mariusz@…>]

In f5b39b7:

Fixed #34535 -- Fixed SQLite dbshell crash on pathlib.Path when handling CommandError.

Regression in 5b884d45ac5b76234eca614d90c83b347294c332.

[Adam Johnson]

I also just hit this. Thanks for the fix.

For completeness, the "sometimes" depends on the exit code of SQLite, which is non-zero if the last run query was an error, for example:

$ ./manage.py dbshell
SQLite version 3.39.5 2022-10-14 20:58:05
Enter ".help" for usage hints.
sqlite> select;
Parse error: near ";": syntax error
  select;
        ^--- error here
sqlite> ^D
Traceback (most recent call last):
...
TypeError: sequence item 1: expected str instance, PosixPath found