Opened 13 months ago
Last modified 7 weeks ago
#34479 new Cleanup/optimization
Support "watchfiles" in the autoreloader
| Reported by: | Tom Forbes | Owned by: | |
|---|---|---|---|
| Component: | Utilities | Version: | 4.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Ülgen Sarıkavak | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
As per https://forum.djangoproject.com/t/the-future-of-the-watchman-autoreloader/19973, I believe we should drop support for the pywatchman autoreloader backend and switch to watchfiles. The current pywatchman implementation is broken.
This should make it a bit easier to test, and the implementation seems like it will be simpler than our watchman implementation.
Change History (8)
comment:1 by , 13 months ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Type: | New feature → Cleanup/optimization |
comment:2 by , 13 months ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:3 by , 12 months ago
Seems like Tom already has a PR for it (https://github.com/django/django/pull/16747). But I don't think much work has been done on it in the past month. Anyways, I would like to work on this one if Tom isn't already working on it.
comment:4 by , 7 weeks ago
| Cc: | added |
|---|
follow-up: 6 comment:5 by , 7 weeks ago
Ülgen, Can I ask why you added yourself to CC in hundreds of tickets in the last way days? You can use a django-updates mailing list or follow the timeline to track updates on all tickets.
follow-up: 7 comment:6 by , 7 weeks ago
Replying to Mariusz Felisiak:
Ülgen, Can I ask why you added yourself to CC in hundreds of tickets in the last way days? You can use a django-updates mailing list or follow the timeline to track updates on all tickets.
Hey Maurizs. I was checking issues before the next sessions of Djangonaut Space and GSoC. According to my notes, it shouldn't be more than 50 issues so far, and I did go over almost 600 issues to select a small portion of them that interests me and the people I work with. I believe this is a proper use of the CC feature, but if it is creating notifications for all those other people and there is no way to deactivate it on my end, I'll be more careful about it. Thanks for the comment and the direction.
comment:7 by , 7 weeks ago
Replying to Ülgen Sarıkavak:
According to my notes, it shouldn't be more than 50 issues so far,
120 :) I think it's more than enough for GSoC and Djangonaut space. Crossing fingers that they will be fixed by you.
Cool 👍 Looks like a fair bit of support from the community to improve it, just need to determine what the improvement is?
Are you going to assign yourself Tom?