Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#34460 closed Cleanup/optimization (wontfix)

Replace Flake8 by Ruff

Reported by: Obi Owned by: nobody
Component: Utilities Version: 4.2
Severity: Normal Keywords: Linter Ruff Flake8
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Flake8 is quite slow and limited as a Linter.

Ruff is more modern, complete and way faster.
https://github.com/charliermarsh/ruff

Here's a pull request to add Ruff Configuration to Django
https://github.com/django/django/pull/16730

I configured it so that all errors he was able to detect are now in the ignored list.
All those were detected in less than one second.

Change History (2)

comment:1 by David Sanders, 20 months ago

Resolution: wontfix
Status: newclosed

Didn't felixx already reject the PR :D

Ruff may one day become the defacto standard over flake8 at which point it could be worth revisiting.

in reply to:  1 comment:2 by Obi, 20 months ago

Replying to David Sanders:

Didn't felixx already reject the PR :D

Ruff may one day become the defacto standard over flake8 at which point it could be worth revisiting.

Sorry, I didn't want to waste both your time, I just wanted to be sure I tried everything for my first contribution to my most beloved tool. :D
I thought you would be interested by Ruff detection results.
Feel free to re-open this ticket if one day you change your mind.
I would love to finish what I started by integrating it to the CI and to use it to improve Django's code.
Keep up the good work. ;)

Note: See TracTickets for help on using tickets.
Back to Top