Opened 3 years ago

Closed 3 years ago

Last modified 10 months ago

#34355 closed Cleanup/optimization (fixed)

Make BaseConstraint arguments keyword-only

Reported by: xafer Owned by: xafer
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Mariusz Felisiak Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As suggested in ​https://github.com/django/django/pull/16560#pullrequestreview-1305496392

I think we should change the signature of BaseConstraint to use keyword-only arguments as a separate cleanup

name and violation_error_message are already keyword-only in all the BaseConstraint subclasses in Django code base.

Change History (7)

comment:1 by xafer, 3 years ago

Owner: changed from nobody to xafer
Status: new → assigned

comment:2 by xafer, 3 years ago

Has patch: set

Cf ​PR

comment:3 by Mariusz Felisiak, 3 years ago

Triage Stage: Unreviewed → Accepted

comment:4 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

comment:5 by Mariusz Felisiak, 3 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In ad18a010:

Fixed #34355 -- Deprecated passing positional arguments to BaseConstraint.

comment:7 by Sarah Boyce <42296566+sarahboyce@…>, 10 months ago

In b5a6c93a:

Refs #34355 -- Removed support for positional arguments in BaseConstraint per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top