Opened 21 months ago
Closed 21 months ago
#34355 closed Cleanup/optimization (fixed)
Make BaseConstraint arguments keyword-only
Reported by: | xafer | Owned by: | xafer |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Mariusz Felisiak | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
As suggested in https://github.com/django/django/pull/16560#pullrequestreview-1305496392
I think we should change the signature of BaseConstraint to use keyword-only arguments as a separate cleanup
name
and violation_error_message
are already keyword-only in all the BaseConstraint
subclasses in Django code base.
Change History (6)
comment:1 by , 21 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 21 months ago
Has patch: | set |
---|
comment:3 by , 21 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:4 by , 21 months ago
Patch needs improvement: | set |
---|
comment:5 by , 21 months ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Cf PR