Opened 23 months ago
Closed 13 months ago
#34305 closed Cleanup/optimization (fixed)
Refactor the GeoIP2 tests to use MaxMind test data
Reported by: | Jacob Walls | Owned by: | Nick Pope |
---|---|---|---|
Component: | GIS | Version: | dev |
Severity: | Normal | Keywords: | geoip, geoip2, maxmind, maxmind-db, mmdb |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Attempted to run the gis_tests
today. Ran into the django-docker-box issue that depends on a refactor in Django itself, so opening a ticket here to track that work.
Essentially, Tom Forbes proposes committing MaxMind test data to the django repo to enable the test_geoip2
to run without having to download the city and country test files. Looking at the PR, a small refactor was also necessary to enable using @override_settings
to point to the files.
Change History (6)
comment:1 by , 23 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 13 months ago
Keywords: | geoip geoip2 maxmind maxmind-db mmdb added |
---|---|
Owner: | changed from | to
Patch needs improvement: | unset |
comment:4 by , 13 months ago
Triage Stage: | Accepted → Ready for checkin |
---|
Note:
See TracTickets
for help on using tickets.
Looks good! Please refer to this ticket number in the commit message.