Code

Opened 7 years ago

Closed 6 years ago

#3428 closed (wontfix)

[full-history] Small fixes to the code

Reported by: ramiro <rm0 _at_ gmx.net> Owned by: nobody
Component: Uncategorized Version: other branch
Severity: Keywords:
Cc: Triage Stage: Someday/Maybe
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

This patch fixes:

  • There are some TAB chars indenting the Python code. From the context it can be deduced that they were used to represent 8 spaces.
  • In django/contrib/history/models.py: The Pickle.dumps call in save_new_revision() uses named protocol=0 as a second parameter. It gives me an error under Python 2.3 (and this result in the the save operation failing always) but from the Python 2.5 [1]documentation it's clear than nothing has changed since 2.3 times in that method. The fix is just call it using 0 or not use it at all.

This patch is against the branch code as of [4459]

Attachments (1)

full-history-r4459.diff (9.6 KB) - added by ramiro <rm0 _at_ gmx.net> 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by ramiro <rm0 _at_ gmx.net>

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin
  • Version changed from SVN to other branch

comment:2 Changed 7 years ago by utrebec

(In [4739]) [full-history]
Refs #3428 -- Removed 'protocol=0' parameter

comment:3 Changed 6 years ago by PJCrosier

  • Summary changed from [full-history] [patch] Small fixes to the code to [full-history] Small fixes to the code

comment:4 Changed 6 years ago by jacob

  • Triage Stage changed from Ready for checkin to Someday/Maybe

comment:5 Changed 6 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from new to closed

The full-history branch is inactive and won't be updated any further. Alternate solutions to the problem can be attempted without changing Django's core nearly as much these days (it's a lot more customisable) and approaches are encouraged. But we aren't going to apply patches to the branch.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.