Opened 17 years ago

Closed 15 years ago

#3428 closed (wontfix)

[full-history] Small fixes to the code

Reported by: ramiro <rm0 _at_ gmx.net> Owned by: nobody
Component: Uncategorized Version: other branch
Severity: Keywords:
Cc: Triage Stage: Someday/Maybe
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This patch fixes:

  • There are some TAB chars indenting the Python code. From the context it can be deduced that they were used to represent 8 spaces.
  • In django/contrib/history/models.py: The Pickle.dumps call in save_new_revision() uses named protocol=0 as a second parameter. It gives me an error under Python 2.3 (and this result in the the save operation failing always) but from the Python 2.5 [1]documentation it's clear than nothing has changed since 2.3 times in that method. The fix is just call it using 0 or not use it at all.

This patch is against the branch code as of [4459]

Attachments (1)

full-history-r4459.diff (9.6 KB ) - added by ramiro <rm0 _at_ gmx.net> 17 years ago.

Download all attachments as: .zip

Change History (6)

by ramiro <rm0 _at_ gmx.net>, 17 years ago

Attachment: full-history-r4459.diff added

comment:1 by Simon G. <dev@…>, 17 years ago

Has patch: set
Triage Stage: UnreviewedReady for checkin
Version: SVNother branch

comment:2 by utrebec, 17 years ago

(In [4739]) [full-history]
Refs #3428 -- Removed 'protocol=0' parameter

comment:3 by Pete Crosier, 16 years ago

Summary: [full-history] [patch] Small fixes to the code[full-history] Small fixes to the code

comment:4 by Jacob, 16 years ago

Triage Stage: Ready for checkinSomeday/Maybe

comment:5 by Malcolm Tredinnick, 15 years ago

Resolution: wontfix
Status: newclosed

The full-history branch is inactive and won't be updated any further. Alternate solutions to the problem can be attempted without changing Django's core nearly as much these days (it's a lot more customisable) and approaches are encouraged. But we aren't going to apply patches to the branch.

Note: See TracTickets for help on using tickets.
Back to Top